summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSenthil Kumaran <orsenthil@gmail.com>2010-02-20 22:30:21 (GMT)
committerSenthil Kumaran <orsenthil@gmail.com>2010-02-20 22:30:21 (GMT)
commit0e7e9aee59809762f929df04c638bf01ebd0ed4d (patch)
tree37e324ad113282774f7283ad676eea5acc12e427
parent39440b14cd4481e138bce568d81663315f1f7cc4 (diff)
downloadcpython-0e7e9aee59809762f929df04c638bf01ebd0ed4d.zip
cpython-0e7e9aee59809762f929df04c638bf01ebd0ed4d.tar.gz
cpython-0e7e9aee59809762f929df04c638bf01ebd0ed4d.tar.bz2
Merged revisions 78270 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k ........ r78270 | senthil.kumaran | 2010-02-21 03:49:04 +0530 (Sun, 21 Feb 2010) | 4 lines Merged revisions 78268 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........
-rw-r--r--Lib/test/test_urllib.py6
-rw-r--r--Lib/urllib/request.py2
2 files changed, 6 insertions, 2 deletions
diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index ad0c100..f4b3766 100644
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -113,7 +113,6 @@ class urlopen_FileTests(unittest.TestCase):
for line in self.returned_obj.__iter__():
self.assertEqual(line, self.text)
-
class ProxyTests(unittest.TestCase):
def setUp(self):
@@ -868,6 +867,11 @@ class URLopener_Tests(unittest.TestCase):
self.assertEqual(DummyURLopener().open(
'spam://example/ /'),'//example/%20/')
+ # test the safe characters are not quoted by urlopen
+ self.assertEqual(DummyURLopener().open(
+ "spam://c:|windows%/:=&?~#+!$,;'@()*[]|/path/"),
+ "//c:|windows%/:=&?~#+!$,;'@()*[]|/path/")
+
# Just commented them out.
# Can't really tell why keep failing in windows and sparc.
# Everywhere else they work ok, but on those machines, someteimes
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index 8229764..9e02962 100644
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -1426,7 +1426,7 @@ class URLopener:
def open(self, fullurl, data=None):
"""Use URLopener().open(file) instead of open(file, 'r')."""
fullurl = unwrap(to_bytes(fullurl))
- fullurl = quote(fullurl, safe="%/:=&?~#+!$,;'@()*[]")
+ fullurl = quote(fullurl, safe="%/:=&?~#+!$,;'@()*[]|")
if self.tempcache and fullurl in self.tempcache:
filename, headers = self.tempcache[fullurl]
fp = open(filename, 'rb')