diff options
| author | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2008-08-22 22:05:20 (GMT) |
|---|---|---|
| committer | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2008-08-22 22:05:20 (GMT) |
| commit | 20443f30436cd93b491286a596063a9ede832467 (patch) | |
| tree | 465fc9c9cff4dfdce3bfa25364b6f380f91d4d34 | |
| parent | b6f9806bd6d5495271e14029acc1e8f1e7de97bc (diff) | |
| download | cpython-20443f30436cd93b491286a596063a9ede832467.zip cpython-20443f30436cd93b491286a596063a9ede832467.tar.gz cpython-20443f30436cd93b491286a596063a9ede832467.tar.bz2 | |
#3650: fix a reference leak in bytes.split('x')
Actually the same as r65785, but trunk only has bytearray.
| -rw-r--r-- | Misc/NEWS | 2 | ||||
| -rw-r--r-- | Objects/bytesobject.c | 14 |
2 files changed, 12 insertions, 4 deletions
@@ -12,6 +12,8 @@ What's New in Python 3.0 release candidate 1 Core and Builtins ----------------- +- Issue #3650: Fixed a reference leak in bytes.split('x'). + Library ------- diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c index 52479ca..bfb4ff8 100644 --- a/Objects/bytesobject.c +++ b/Objects/bytesobject.c @@ -1163,8 +1163,11 @@ string_split(PyBytesObject *self, PyObject *args) PyBuffer_Release(&vsub); return NULL; } - else if (n == 1) - return split_char(self, len, sub[0], maxsplit); + else if (n == 1) { + list = split_char(self, len, sub[0], maxsplit); + PyBuffer_Release(&vsub); + return list; + } list = PyList_New(PREALLOC_SIZE(maxsplit)); if (list == NULL) { @@ -1379,8 +1382,11 @@ string_rsplit(PyBytesObject *self, PyObject *args) PyBuffer_Release(&vsub); return NULL; } - else if (n == 1) - return rsplit_char(self, len, sub[0], maxsplit); + else if (n == 1) { + list = rsplit_char(self, len, sub[0], maxsplit); + PyBuffer_Release(&vsub); + return list; + } list = PyList_New(PREALLOC_SIZE(maxsplit)); if (list == NULL) { |