summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSenthil Kumaran <orsenthil@gmail.com>2011-04-15 10:22:05 (GMT)
committerSenthil Kumaran <orsenthil@gmail.com>2011-04-15 10:22:05 (GMT)
commitb496159603e5cc31904a894166ecce52fea01a1c (patch)
tree947788534cea9802e60046e3f74fb0c335999603
parent0dea6484a05759258151800d0b604ea4820f6bb3 (diff)
parentb4bd4af8c4adb03978803b5d94241a87e40bdaf9 (diff)
downloadcpython-b496159603e5cc31904a894166ecce52fea01a1c.zip
cpython-b496159603e5cc31904a894166ecce52fea01a1c.tar.gz
cpython-b496159603e5cc31904a894166ecce52fea01a1c.tar.bz2
merge from 3.2
-rw-r--r--Lib/test/test_urlparse.py5
-rw-r--r--Lib/urllib/parse.py15
-rw-r--r--Misc/NEWS3
3 files changed, 18 insertions, 5 deletions
diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py
index 628b8ec..c8d572c 100644
--- a/Lib/test/test_urlparse.py
+++ b/Lib/test/test_urlparse.py
@@ -228,6 +228,11 @@ class UrlParseTestCase(unittest.TestCase):
#self.checkJoin(RFC1808_BASE, 'http:g', 'http:g')
#self.checkJoin(RFC1808_BASE, 'http:', 'http:')
+ def test_RFC2368(self):
+ # Issue 11467: path that starts with a number is not parsed correctly
+ self.assertEqual(urllib.parse.urlparse('mailto:1337@example.org'),
+ ('mailto', '', '1337@example.org', '', '', ''))
+
def test_RFC2396(self):
# cases from RFC 2396
diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
index 9a3e42e..45ae202 100644
--- a/Lib/urllib/parse.py
+++ b/Lib/urllib/parse.py
@@ -340,12 +340,17 @@ def urlsplit(url, scheme='', allow_fragments=True):
v = SplitResult(scheme, netloc, url, query, fragment)
_parse_cache[key] = v
return _coerce_result(v)
- if url.endswith(':') or not url[i+1].isdigit():
- for c in url[:i]:
- if c not in scheme_chars:
- break
- else:
+ for c in url[:i]:
+ if c not in scheme_chars:
+ break
+ else:
+ try:
+ # make sure "url" is not actually a port number (in which case
+ # "scheme" is really part of the path
+ _testportnum = int(url[i+1:])
+ except ValueError:
scheme, url = url[:i].lower(), url[i+1:]
+
if url[:2] == '//':
netloc, url = _splitnetloc(url, 2)
if (('[' in netloc and ']' not in netloc) or
diff --git a/Misc/NEWS b/Misc/NEWS
index 553adcd..d95576e 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -106,6 +106,9 @@ Core and Builtins
Library
-------
+- Issue #11467: Fix urlparse behavior when handling urls which contains scheme
+ specific part only digits. Patch by Santoso Wijaya.
+
- Issue #11474: Fix the bug with url2pathname() handling of '/C|/' on Windows.
Patch by Santoso Wijaya.