summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@haypocalc.com>2011-06-15 21:58:57 (GMT)
committerVictor Stinner <victor.stinner@haypocalc.com>2011-06-15 21:58:57 (GMT)
commit4e97abce2df7f5bd7c34f5694e222997282edf7f (patch)
treecd7725f05c36418107a6755843e6ead5061948e0
parenta1969e0cbf69aefa7d419c6b848bc969b97e3d2f (diff)
downloadcpython-4e97abce2df7f5bd7c34f5694e222997282edf7f.zip
cpython-4e97abce2df7f5bd7c34f5694e222997282edf7f.tar.gz
cpython-4e97abce2df7f5bd7c34f5694e222997282edf7f.tar.bz2
Issue #12167: Fix a reafleak in packaging.tests.PyPIServer constructor
Don't modify mutable default arguments...
-rw-r--r--Lib/packaging/tests/pypi_server.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/Lib/packaging/tests/pypi_server.py b/Lib/packaging/tests/pypi_server.py
index cdff07c..2baf8ba 100644
--- a/Lib/packaging/tests/pypi_server.py
+++ b/Lib/packaging/tests/pypi_server.py
@@ -88,7 +88,7 @@ class PyPIServer(threading.Thread):
"""
def __init__(self, test_static_path=None,
- static_filesystem_paths=["default"],
+ static_filesystem_paths=None,
static_uri_paths=["simple", "packages"], serve_xmlrpc=False):
"""Initialize the server.
@@ -105,6 +105,8 @@ class PyPIServer(threading.Thread):
threading.Thread.__init__(self)
self._run = True
self._serve_xmlrpc = serve_xmlrpc
+ if static_filesystem_paths is None:
+ static_filesystem_paths = ["default"]
#TODO allow to serve XMLRPC and HTTP static files at the same time.
if not self._serve_xmlrpc: