summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2014-09-30 16:11:00 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2014-09-30 16:11:00 (GMT)
commit63860e5407e9ac1251e0698fb2d208a1da54bd3c (patch)
tree32c1557578bd74cfec9eda3759099cf83d20097d
parentcb1115a43d0d520820c54d34fa53d49f3ccb0d31 (diff)
parent68da8fc4c0b4b2f640bd09b7b0e3214b263fac0d (diff)
downloadcpython-63860e5407e9ac1251e0698fb2d208a1da54bd3c.zip
cpython-63860e5407e9ac1251e0698fb2d208a1da54bd3c.tar.gz
cpython-63860e5407e9ac1251e0698fb2d208a1da54bd3c.tar.bz2
(Merge 3.4) Issue #22448: asyncio, cleanup _run_once(), only iterate once to
remove delayed calls that were cancelled.
-rw-r--r--Lib/asyncio/base_events.py11
1 files changed, 7 insertions, 4 deletions
diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
index 5aaf58f..3cff72a 100644
--- a/Lib/asyncio/base_events.py
+++ b/Lib/asyncio/base_events.py
@@ -994,19 +994,22 @@ class BaseEventLoop(events.AbstractEventLoop):
'call_later' callbacks.
"""
- # Remove delayed calls that were cancelled if their number is too high
sched_count = len(self._scheduled)
if (sched_count > _MIN_SCHEDULED_TIMER_HANDLES and
self._timer_cancelled_count / sched_count >
_MIN_CANCELLED_TIMER_HANDLES_FRACTION):
+ # Remove delayed calls that were cancelled if their number
+ # is too high
+ new_scheduled = []
for handle in self._scheduled:
if handle._cancelled:
handle._scheduled = False
+ else:
+ new_scheduled.append(handle)
- self._scheduled = [x for x in self._scheduled if not x._cancelled]
+ heapq.heapify(new_scheduled)
+ self._scheduled = new_scheduled
self._timer_cancelled_count = 0
-
- heapq.heapify(self._scheduled)
else:
# Remove delayed calls that were cancelled from head of queue.
while self._scheduled and self._scheduled[0]._cancelled: