diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-09-01 13:04:47 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-01 13:04:47 (GMT) |
| commit | 98c849a2f32f6727239b4cce38b8f0ff8adeef22 (patch) | |
| tree | 4d9015d7c54ade267819b6726a41d342c40ba09e | |
| parent | 60f3f1fb5cbf5354c3081138be806c56cb04153f (diff) | |
| download | cpython-98c849a2f32f6727239b4cce38b8f0ff8adeef22.zip cpython-98c849a2f32f6727239b4cce38b8f0ff8adeef22.tar.gz cpython-98c849a2f32f6727239b4cce38b8f0ff8adeef22.tar.bz2 | |
bpo-31217: Fix regrtest -R for small integer (#3260) (#3261)
Use a pool of integer objects toprevent false alarm when checking for
memory block leaks. Fill the pool with values in -1000..1000 which
are the most common (reference, memory block, file descriptor)
differences.
Co-Authored-By: Antoine Pitrou <pitrou@free.fr>
(cherry picked from commit 6c2feabc5dac2f3049b15134669e9ad5af573193)
| -rw-r--r-- | Lib/test/libregrtest/refleak.py | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/Lib/test/libregrtest/refleak.py b/Lib/test/libregrtest/refleak.py index 8e93816..0bd8288 100644 --- a/Lib/test/libregrtest/refleak.py +++ b/Lib/test/libregrtest/refleak.py @@ -68,6 +68,14 @@ def dash_R(the_module, test, indirect_test, huntrleaks): for obj in abc.__subclasses__() + [abc]: abcs[obj] = obj._abc_registry.copy() + # bpo-31217: Integer pool to get a single integer object for the same + # value. The pool is used to prevent false alarm when checking for memory + # block leaks. Fill the pool with values in -1000..1000 which are the most + # common (reference, memory block, file descriptor) differences. + int_pool = {value: value for value in range(-1000, 1000)} + def get_pooled_int(value): + return int_pool.setdefault(value, value) + nwarmup, ntracked, fname = huntrleaks fname = os.path.join(support.SAVEDCWD, fname) repcount = nwarmup + ntracked @@ -86,9 +94,9 @@ def dash_R(the_module, test, indirect_test, huntrleaks): abcs) print('.', end='', file=sys.stderr, flush=True) if i >= nwarmup: - rc_deltas[i] = rc_after - rc_before - alloc_deltas[i] = alloc_after - alloc_before - fd_deltas[i] = fd_after - fd_before + rc_deltas[i] = get_pooled_int(rc_after - rc_before) + alloc_deltas[i] = get_pooled_int(alloc_after - alloc_before) + fd_deltas[i] = get_pooled_int(fd_after - fd_before) alloc_before = alloc_after rc_before = rc_after fd_before = fd_after |