summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Coghlan <ncoghlan@gmail.com>2012-01-14 06:45:48 (GMT)
committerNick Coghlan <ncoghlan@gmail.com>2012-01-14 06:45:48 (GMT)
commit138f4656e38f656afa7436c306aa74f1d4941216 (patch)
tree6727c9f1a5461de10e822260c264397f955019d3
parent76e1bb0ef9eab6b937e03816e403a5b4a8c169fa (diff)
downloadcpython-138f4656e38f656afa7436c306aa74f1d4941216.zip
cpython-138f4656e38f656afa7436c306aa74f1d4941216.tar.gz
cpython-138f4656e38f656afa7436c306aa74f1d4941216.tar.bz2
Add a separate NEWS entry for a change to PyObject_CallMethod in the PEP 380 patch, and make the private CallMethod variants consistent with the public one
-rw-r--r--Misc/NEWS3
-rw-r--r--Objects/abstract.c2
2 files changed, 3 insertions, 2 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index d3930ed..6531ddd 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -2449,6 +2449,9 @@ Library
C-API
-----
+- PyObject_CallMethod now passes along any underlying AttributeError from
+ PyObject_GetAttr, instead of replacing it with something less informative
+
- Issue #10913: Deprecate misleading functions PyEval_AcquireLock() and
PyEval_ReleaseLock(). The thread-state aware APIs should be used instead.
diff --git a/Objects/abstract.c b/Objects/abstract.c
index 4d73a3b..be568c6 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -2288,7 +2288,6 @@ _PyObject_CallMethodId(PyObject *o, _Py_Identifier *name, char *format, ...)
func = _PyObject_GetAttrId(o, name);
if (func == NULL) {
- PyErr_SetString(PyExc_AttributeError, name->string);
return 0;
}
@@ -2330,7 +2329,6 @@ _PyObject_CallMethodId_SizeT(PyObject *o, _Py_Identifier *name, char *format, ..
func = _PyObject_GetAttrId(o, name);
if (func == NULL) {
- PyErr_SetString(PyExc_AttributeError, name->string);
return NULL;
}
va_start(va, format);