summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-07-14 09:25:43 (GMT)
committerGitHub <noreply@github.com>2019-07-14 09:25:43 (GMT)
commit3958b7aae8cc7c571a842ff43c1dea1da9abdd9d (patch)
treed3d35bd25e94708b0fa469b485813b0ab63408e6
parent7a430109b983806c57babf229c60d0245d0b541c (diff)
downloadcpython-3958b7aae8cc7c571a842ff43c1dea1da9abdd9d.zip
cpython-3958b7aae8cc7c571a842ff43c1dea1da9abdd9d.tar.gz
cpython-3958b7aae8cc7c571a842ff43c1dea1da9abdd9d.tar.bz2
Clarify that plistlib's load and dump functions take a binary file object (GH-9825)
The documentation says that the fp parameter to plistlib.load "should be a readable and binary file object" but the docstring only mentions that it should be readable. Similarly, plistlib.dump's docstring only mentions "writable". This commit clarifies that fp should also be binary. https://docs.python.org/3/library/plistlib.htmlGH-plistlib.load https://docs.python.org/3/library/plistlib.htmlGH-plistlib.dump (cherry picked from commit 0d4f4352efecf1b044c88e234e71774fe04b7d6c) Co-authored-by: Collin Styles <collingstyles@gmail.com>
-rw-r--r--Lib/plistlib.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/Lib/plistlib.py b/Lib/plistlib.py
index 0133c89..04f8a87 100644
--- a/Lib/plistlib.py
+++ b/Lib/plistlib.py
@@ -971,7 +971,7 @@ _FORMATS={
def load(fp, *, fmt=None, use_builtin_types=True, dict_type=dict):
- """Read a .plist file. 'fp' should be (readable) file object.
+ """Read a .plist file. 'fp' should be a readable and binary file object.
Return the unpacked root object (which usually is a dictionary).
"""
if fmt is None:
@@ -1002,8 +1002,8 @@ def loads(value, *, fmt=None, use_builtin_types=True, dict_type=dict):
def dump(value, fp, *, fmt=FMT_XML, sort_keys=True, skipkeys=False):
- """Write 'value' to a .plist file. 'fp' should be a (writable)
- file object.
+ """Write 'value' to a .plist file. 'fp' should be a writable,
+ binary file object.
"""
if fmt not in _FORMATS:
raise ValueError("Unsupported format: %r"%(fmt,))