summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuido van Rossum <guido@python.org>2019-05-28 23:44:58 (GMT)
committerGitHub <noreply@github.com>2019-05-28 23:44:58 (GMT)
commit77f0ed7a42606d03ebfe48ab152caf0d796d6540 (patch)
tree1aab5bc929a5d50b3a4820ce7fdb2c05aafd6a73
parent44bfff2ec220f2e0291150a776d4d77af7c821ef (diff)
downloadcpython-77f0ed7a42606d03ebfe48ab152caf0d796d6540.zip
cpython-77f0ed7a42606d03ebfe48ab152caf0d796d6540.tar.gz
cpython-77f0ed7a42606d03ebfe48ab152caf0d796d6540.tar.bz2
bpo-37072: Fix crash in PyAST_FromNodeObject() when flags is NULL (#13634)
I'm confident that this fixes the reported crash. flags=NULL is treated as using the latest minor version. https://bugs.python.org/issue37072
-rw-r--r--Misc/NEWS.d/next/Core and Builtins/2019-05-28-18-18-55.bpo-37072.1Hewl3.rst1
-rw-r--r--Python/ast.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-05-28-18-18-55.bpo-37072.1Hewl3.rst b/Misc/NEWS.d/next/Core and Builtins/2019-05-28-18-18-55.bpo-37072.1Hewl3.rst
new file mode 100644
index 0000000..15bcc5e
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2019-05-28-18-18-55.bpo-37072.1Hewl3.rst
@@ -0,0 +1 @@
+Fix crash in PyAST_FromNodeObject() when flags is NULL. \ No newline at end of file
diff --git a/Python/ast.c b/Python/ast.c
index 7ffdf4a..12a45f9 100644
--- a/Python/ast.c
+++ b/Python/ast.c
@@ -786,7 +786,7 @@ PyAST_FromNodeObject(const node *n, PyCompilerFlags *flags,
/* borrowed reference */
c.c_filename = filename;
c.c_normalize = NULL;
- c.c_feature_version = flags->cf_feature_version;
+ c.c_feature_version = flags ? flags->cf_feature_version : PY_MINOR_VERSION;
if (TYPE(n) == encoding_decl)
n = CHILD(n, 0);