summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNadeem Vawda <nadeem.vawda@gmail.com>2011-05-07 11:01:50 (GMT)
committerNadeem Vawda <nadeem.vawda@gmail.com>2011-05-07 11:01:50 (GMT)
commitced1056925420a67a5cce86287122429700ad52e (patch)
tree4e30d9e27c765d88ab21dbe340b6951bb8c675f6
parentcaed7fe0ffeadb681d175320574d4d51c060f07b (diff)
downloadcpython-ced1056925420a67a5cce86287122429700ad52e.zip
cpython-ced1056925420a67a5cce86287122429700ad52e.tar.gz
cpython-ced1056925420a67a5cce86287122429700ad52e.tar.bz2
Issue #11277: Add tests for mmap crash when using large sparse files on OS X.
Also, reduce code duplication in LargeMmapTests. Original patch by Steffen Daode Nurpmeso.
-rw-r--r--Lib/test/test_mmap.py60
1 files changed, 34 insertions, 26 deletions
diff --git a/Lib/test/test_mmap.py b/Lib/test/test_mmap.py
index 7c51085..fbc34ed 100644
--- a/Lib/test/test_mmap.py
+++ b/Lib/test/test_mmap.py
@@ -1,4 +1,5 @@
-from test.support import TESTFN, run_unittest, import_module, unlink, requires
+from test.support import (TESTFN, run_unittest, import_module, unlink,
+ requires, _2G, _4G)
import unittest
import os, re, itertools, socket, sys
@@ -653,28 +654,20 @@ class LargeMmapTests(unittest.TestCase):
def tearDown(self):
unlink(TESTFN)
- def _working_largefile(self):
- # Only run if the current filesystem supports large files.
- f = open(TESTFN, 'wb', buffering=0)
- try:
- f.seek(0x80000001)
- f.write(b'x')
- f.flush()
- except (IOError, OverflowError):
- raise unittest.SkipTest("filesystem does not have largefile support")
- finally:
- f.close()
- unlink(TESTFN)
-
- def test_large_offset(self):
+ def _create_test_file(self, num_zeroes, tail):
if sys.platform[:3] == 'win' or sys.platform == 'darwin':
requires('largefile',
'test requires %s bytes and a long time to run' % str(0x180000000))
- self._working_largefile()
with open(TESTFN, 'wb') as f:
- f.seek(0x14FFFFFFF)
- f.write(b" ")
+ try:
+ f.seek(num_zeroes)
+ f.write(tail)
+ f.flush()
+ except (IOError, OverflowError):
+ raise unittest.SkipTest("filesystem does not have largefile support")
+ def test_large_offset(self):
+ self._create_test_file(0x14FFFFFFF, b" ")
with open(TESTFN, 'rb') as f:
m = mmap.mmap(f.fileno(), 0, offset=0x140000000, access=mmap.ACCESS_READ)
try:
@@ -683,14 +676,7 @@ class LargeMmapTests(unittest.TestCase):
m.close()
def test_large_filesize(self):
- if sys.platform[:3] == 'win' or sys.platform == 'darwin':
- requires('largefile',
- 'test requires %s bytes and a long time to run' % str(0x180000000))
- self._working_largefile()
- with open(TESTFN, 'wb') as f:
- f.seek(0x17FFFFFFF)
- f.write(b" ")
-
+ self._create_test_file(0x17FFFFFFF, b" ")
with open(TESTFN, 'rb') as f:
m = mmap.mmap(f.fileno(), 0x10000, access=mmap.ACCESS_READ)
try:
@@ -698,6 +684,28 @@ class LargeMmapTests(unittest.TestCase):
finally:
m.close()
+ # Issue 11277: mmap() with large (~4GB) sparse files crashes on OS X.
+
+ def _test_around_boundary(self, boundary):
+ tail = b' DEARdear '
+ start = boundary - len(tail) // 2
+ end = start + len(tail)
+ self._create_test_file(start, tail)
+ with open(TESTFN, 'rb') as f:
+ m = mmap.mmap(f.fileno(), 0, access=mmap.ACCESS_READ)
+ try:
+ self.assertEqual(m[start:end], tail)
+ finally:
+ m.close()
+
+ @unittest.skipUnless(sys.maxsize > _4G, "test cannot run on 32-bit systems")
+ def test_around_2GB(self):
+ self._test_around_boundary(_2G)
+
+ @unittest.skipUnless(sys.maxsize > _4G, "test cannot run on 32-bit systems")
+ def test_around_4GB(self):
+ self._test_around_boundary(_4G)
+
def test_main():
run_unittest(MmapTests, LargeMmapTests)