summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2016-02-18 06:18:20 (GMT)
committerBenjamin Peterson <benjamin@python.org>2016-02-18 06:18:20 (GMT)
commit1378f7ca68329e6eebdd1b47bcb7b86fca2aff24 (patch)
treec1177b662e6a9dbc5bea45dcb120c425ee3e4d56
parentf38c93fb7f9b8e127ff94e47beaad2f13dfdf11a (diff)
parent94912727513ccab03567cfcab01732989c0ababc (diff)
downloadcpython-1378f7ca68329e6eebdd1b47bcb7b86fca2aff24.zip
cpython-1378f7ca68329e6eebdd1b47bcb7b86fca2aff24.tar.gz
cpython-1378f7ca68329e6eebdd1b47bcb7b86fca2aff24.tar.bz2
merge 3.4 (closes #25939)
-rw-r--r--Misc/NEWS2
-rw-r--r--Modules/_ssl.c8
2 files changed, 8 insertions, 2 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index 6446e7d..20be117 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -76,6 +76,8 @@ Core and Builtins
Library
-------
+- Issue #25939: On Windows open the cert store readonly in ssl.enum_certificates.
+
- Issue #25995: os.walk() no longer uses FDs proportional to the tree depth.
- Issue #26117: The os.scandir() iterator now closes file descriptor not only
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 1c68000..3377138 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -4198,7 +4198,9 @@ _ssl_enum_certificates_impl(PyModuleDef *module, const char *store_name)
if (result == NULL) {
return NULL;
}
- hStore = CertOpenSystemStore((HCRYPTPROV)NULL, store_name);
+ hStore = CertOpenStore(CERT_STORE_PROV_SYSTEM_A, 0, (HCRYPTPROV)NULL,
+ CERT_STORE_READONLY_FLAG | CERT_SYSTEM_STORE_LOCAL_MACHINE,
+ store_name);
if (hStore == NULL) {
Py_DECREF(result);
return PyErr_SetFromWindowsErr(GetLastError());
@@ -4284,7 +4286,9 @@ _ssl_enum_crls_impl(PyModuleDef *module, const char *store_name)
if (result == NULL) {
return NULL;
}
- hStore = CertOpenSystemStore((HCRYPTPROV)NULL, store_name);
+ hStore = CertOpenStore(CERT_STORE_PROV_SYSTEM_A, 0, (HCRYPTPROV)NULL,
+ CERT_STORE_READONLY_FLAG | CERT_SYSTEM_STORE_LOCAL_MACHINE,
+ store_name);
if (hStore == NULL) {
Py_DECREF(result);
return PyErr_SetFromWindowsErr(GetLastError());