diff options
author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2021-04-21 22:53:31 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-04-21 22:53:31 (GMT) |
commit | 602eefef0bd0187049c2ab9071390f8573fc299a (patch) | |
tree | 70da7d512a286d59f66e8fc9ae0a978ef1f99cee | |
parent | 303ffb74a38dfed5c62ca6d8a2d53d80b696feab (diff) | |
download | cpython-602eefef0bd0187049c2ab9071390f8573fc299a.zip cpython-602eefef0bd0187049c2ab9071390f8573fc299a.tar.gz cpython-602eefef0bd0187049c2ab9071390f8573fc299a.tar.bz2 |
bpo-43472: Ensure PyInterpreterState_New audit events are raised when called through _xxsubinterpreters module (GH-25506)
(cherry picked from commit 7b86e47617d81a4b14d929743425f448971e8c86)
Co-authored-by: Steve Dower <steve.dower@python.org>
-rw-r--r-- | Doc/library/sys.rst | 4 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Security/2021-04-21-22-53-31.bpo-43472.gjLBTb.rst | 3 | ||||
-rw-r--r-- | Modules/_xxsubinterpretersmodule.c | 2 |
3 files changed, 6 insertions, 3 deletions
diff --git a/Doc/library/sys.rst b/Doc/library/sys.rst index def2d7e..95cbaf2 100644 --- a/Doc/library/sys.rst +++ b/Doc/library/sys.rst @@ -26,12 +26,12 @@ always available. .. function:: addaudithook(hook) Append the callable *hook* to the list of active auditing hooks for the - current interpreter. + current (sub)interpreter. When an auditing event is raised through the :func:`sys.audit` function, each hook will be called in the order it was added with the event name and the tuple of arguments. Native hooks added by :c:func:`PySys_AddAuditHook` are - called first, followed by hooks added in the current interpreter. Hooks + called first, followed by hooks added in the current (sub)interpreter. Hooks can then log the event, raise an exception to abort the operation, or terminate the process entirely. diff --git a/Misc/NEWS.d/next/Security/2021-04-21-22-53-31.bpo-43472.gjLBTb.rst b/Misc/NEWS.d/next/Security/2021-04-21-22-53-31.bpo-43472.gjLBTb.rst new file mode 100644 index 0000000..e38dc16 --- /dev/null +++ b/Misc/NEWS.d/next/Security/2021-04-21-22-53-31.bpo-43472.gjLBTb.rst @@ -0,0 +1,3 @@ +Ensures interpreter-level audit hooks receive the +``cpython.PyInterpreterState_New`` event when called through the +``_xxsubinterpreters`` module. diff --git a/Modules/_xxsubinterpretersmodule.c b/Modules/_xxsubinterpretersmodule.c index db1116a..bda2a25 100644 --- a/Modules/_xxsubinterpretersmodule.c +++ b/Modules/_xxsubinterpretersmodule.c @@ -1993,7 +1993,7 @@ interp_create(PyObject *self, PyObject *args) } // Create and initialize the new interpreter. - PyThreadState *save_tstate = PyThreadState_Swap(NULL); + PyThreadState *save_tstate = PyThreadState_Get(); // XXX Possible GILState issues? PyThreadState *tstate = Py_NewInterpreter(); PyThreadState_Swap(save_tstate); |