summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Dickinson <dickinsm@gmail.com>2010-06-30 08:32:11 (GMT)
committerMark Dickinson <dickinsm@gmail.com>2010-06-30 08:32:11 (GMT)
commit8d6d760422b56f69e57d009fa26eabcc49935afe (patch)
tree275339a9878be15fb2902fc54774f7226ec8a9d3
parent719e4e3ba5a04bec52a04414383781ece8df1ef3 (diff)
downloadcpython-8d6d760422b56f69e57d009fa26eabcc49935afe.zip
cpython-8d6d760422b56f69e57d009fa26eabcc49935afe.tar.gz
cpython-8d6d760422b56f69e57d009fa26eabcc49935afe.tar.bz2
Collapse else: if: ... into elif:
-rw-r--r--Demo/parser/test_unparse.py22
-rw-r--r--Demo/parser/unparse.py11
2 files changed, 32 insertions, 1 deletions
diff --git a/Demo/parser/test_unparse.py b/Demo/parser/test_unparse.py
index f4a3e66..7d85f16 100644
--- a/Demo/parser/test_unparse.py
+++ b/Demo/parser/test_unparse.py
@@ -64,6 +64,24 @@ class_decorator = """\
class Foo: pass
"""
+elif1 = """\
+if cond1:
+ suite1
+elif cond2:
+ suite2
+else:
+ suite3
+"""
+
+elif2 = """\
+if cond1:
+ suite1
+elif cond2:
+ suite2
+"""
+
+
+
class ASTTestCase(unittest.TestCase):
def assertASTEqual(self, ast1, ast2):
self.assertEqual(ast.dump(ast1), ast.dump(ast2))
@@ -159,6 +177,10 @@ class UnparseTestCase(ASTTestCase):
def test_class_definition(self):
self.check_roundtrip("class A(metaclass=type, *[], **{}): pass")
+ def test_elifs(self):
+ self.check_roundtrip(elif1)
+ self.check_roundtrip(elif2)
+
class DirectoryTestCase(ASTTestCase):
"""Test roundtrip behaviour on all files in Lib and Lib/test."""
diff --git a/Demo/parser/unparse.py b/Demo/parser/unparse.py
index 6e4ef63..03dd9e1 100644
--- a/Demo/parser/unparse.py
+++ b/Demo/parser/unparse.py
@@ -256,9 +256,18 @@ class Unparser:
self.fill("if ")
self.dispatch(t.test)
self.enter()
- # XXX elif?
self.dispatch(t.body)
self.leave()
+ # collapse nested ifs into equivalent elifs.
+ while (t.orelse and len(t.orelse) == 1 and
+ isinstance(t.orelse[0], ast.If)):
+ t = t.orelse[0]
+ self.fill("elif ")
+ self.dispatch(t.test)
+ self.enter()
+ self.dispatch(t.body)
+ self.leave()
+ # final else
if t.orelse:
self.fill("else")
self.enter()