summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorR. David Murray <rdmurray@bitdance.com>2011-03-03 18:03:36 (GMT)
committerR. David Murray <rdmurray@bitdance.com>2011-03-03 18:03:36 (GMT)
commit91221f2857961cfed3411e5c49cfa256d9c6a3f8 (patch)
tree05554ae447559157a8c274c06baf77a17b73e844
parentacdad9a40b4c1d5d70c5d5966cbea61126bdc04e (diff)
downloadcpython-91221f2857961cfed3411e5c49cfa256d9c6a3f8.zip
cpython-91221f2857961cfed3411e5c49cfa256d9c6a3f8.tar.gz
cpython-91221f2857961cfed3411e5c49cfa256d9c6a3f8.tar.bz2
#11306: Treat EROFS like EACCES when making a 'file is read-only' decision
-rw-r--r--Lib/mailbox.py6
-rw-r--r--Misc/NEWS4
2 files changed, 7 insertions, 3 deletions
diff --git a/Lib/mailbox.py b/Lib/mailbox.py
index 2a0d321..ace1709 100644
--- a/Lib/mailbox.py
+++ b/Lib/mailbox.py
@@ -578,7 +578,7 @@ class _singlefileMailbox(Mailbox):
f = open(self._path, 'wb+')
else:
raise NoSuchMailboxError(self._path)
- elif e.errno == errno.EACCES:
+ elif e.errno in (errno.EACCES, errno.EROFS):
f = open(self._path, 'rb')
else:
raise
@@ -2002,7 +2002,7 @@ def _lock_file(f, dotlock=True):
try:
fcntl.lockf(f, fcntl.LOCK_EX | fcntl.LOCK_NB)
except IOError as e:
- if e.errno in (errno.EAGAIN, errno.EACCES):
+ if e.errno in (errno.EAGAIN, errno.EACCES, errno.EROFS):
raise ExternalClashError('lockf: lock unavailable: %s' %
f.name)
else:
@@ -2012,7 +2012,7 @@ def _lock_file(f, dotlock=True):
pre_lock = _create_temporary(f.name + '.lock')
pre_lock.close()
except IOError as e:
- if e.errno == errno.EACCES:
+ if e.errno in (errno.EACCES, errno.EROFS):
return # Without write access, just skip dotlocking.
else:
raise
diff --git a/Misc/NEWS b/Misc/NEWS
index 64e2d59..09b4a95 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -52,6 +52,10 @@ Core and Builtins
Library
-------
+- Issue #11306: mailbox in certain cases adapts to an inability to open
+ certain files in read-write mode. Previously it detected this by
+ checking for EACCES, now it also checks for EROFS.
+
- Issue #11265: asyncore now correctly handles EPIPE, EBADF and EAGAIN errors
on accept(), send() and recv().