summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAmaury Forgeot d'Arc <amauryfa@gmail.com>2008-12-05 01:02:21 (GMT)
committerAmaury Forgeot d'Arc <amauryfa@gmail.com>2008-12-05 01:02:21 (GMT)
commitbc2ce57203e1f355004ec95953eae9dec780ef9a (patch)
tree066d0379437cfd29e77abc3d85cde7331ddbb828
parent9a0a65b524fa5afa91d918977bada03d24f95234 (diff)
downloadcpython-bc2ce57203e1f355004ec95953eae9dec780ef9a.zip
cpython-bc2ce57203e1f355004ec95953eae9dec780ef9a.tar.gz
cpython-bc2ce57203e1f355004ec95953eae9dec780ef9a.tar.bz2
Issue #4537: webbrowser.UnixBrowser failed because this module defines an open()
function which shadows the builtin. Will backport to 3.0
-rw-r--r--Lib/webbrowser.py2
-rw-r--r--Misc/NEWS3
2 files changed, 4 insertions, 1 deletions
diff --git a/Lib/webbrowser.py b/Lib/webbrowser.py
index 4772adc..18dc11b 100644
--- a/Lib/webbrowser.py
+++ b/Lib/webbrowser.py
@@ -223,7 +223,7 @@ class UnixBrowser(BaseBrowser):
cmdline = [self.name] + raise_opt + args
if remote or self.background:
- inout = open(os.devnull, "r+")
+ inout = io.open(os.devnull, "r+")
else:
# for TTY browsers, we need stdin/out
inout = None
diff --git a/Misc/NEWS b/Misc/NEWS
index d4e749f..15e3401 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -16,6 +16,9 @@ Core and Builtins
Library
-------
+- Issue #4537: webbrowser.UnixBrowser would fail to open the browser because
+ it was calling the wrong open() function.
+
- Issue #1055234: cgi.parse_header(): Fixed parsing of header parameters to
support unusual filenames (such as those containing semi-colons) in
Content-Disposition headers.