summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYury Selivanov <yselivanov@sprymix.com>2015-10-02 19:05:59 (GMT)
committerYury Selivanov <yselivanov@sprymix.com>2015-10-02 19:05:59 (GMT)
commit43d71e2512707b959cc1cc850b85c2de99fee138 (patch)
tree4b71d141004abe07e19883318bb1dafafb3232d6
parent987f21514122b83e42b04f9782f53b6f77edb174 (diff)
parent620279b9ace3fff66245672bf7efbb62b2969a30 (diff)
downloadcpython-43d71e2512707b959cc1cc850b85c2de99fee138.zip
cpython-43d71e2512707b959cc1cc850b85c2de99fee138.tar.gz
cpython-43d71e2512707b959cc1cc850b85c2de99fee138.tar.bz2
asyncio: Make ensure_future() accept all kinds of awaitables.
-rw-r--r--Doc/whatsnew/3.5.rst7
-rw-r--r--Lib/asyncio/tasks.py16
-rw-r--r--Lib/test/test_asyncio/test_tasks.py18
-rw-r--r--Misc/NEWS2
4 files changed, 41 insertions, 2 deletions
diff --git a/Doc/whatsnew/3.5.rst b/Doc/whatsnew/3.5.rst
index 56cb00c..cda8a6d 100644
--- a/Doc/whatsnew/3.5.rst
+++ b/Doc/whatsnew/3.5.rst
@@ -803,6 +803,13 @@ Notable changes in the :mod:`asyncio` module since Python 3.4.0:
:class:`asyncio.Queue` class.
(Contributed by Victor Stinner.)
+Updates in 3.5.1:
+
+* The :func:`~asyncio.ensure_future` function and all functions that
+ use it, such as :meth:`loop.run_until_complete() <asyncio.BaseEventLoop.run_until_complete>`,
+ now accept all kinds of :term:`awaitable objects <awaitable>`.
+ (Contributed by Yury Selivanov.)
+
bz2
---
diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py
index a235e74..434f498 100644
--- a/Lib/asyncio/tasks.py
+++ b/Lib/asyncio/tasks.py
@@ -512,7 +512,7 @@ def async(coro_or_future, *, loop=None):
def ensure_future(coro_or_future, *, loop=None):
- """Wrap a coroutine in a future.
+ """Wrap a coroutine or an awaitable in a future.
If the argument is a Future, it is returned directly.
"""
@@ -527,8 +527,20 @@ def ensure_future(coro_or_future, *, loop=None):
if task._source_traceback:
del task._source_traceback[-1]
return task
+ elif compat.PY35 and inspect.isawaitable(coro_or_future):
+ return ensure_future(_wrap_awaitable(coro_or_future), loop=loop)
else:
- raise TypeError('A Future or coroutine is required')
+ raise TypeError('A Future, a coroutine or an awaitable is required')
+
+
+@coroutine
+def _wrap_awaitable(awaitable):
+ """Helper for asyncio.ensure_future().
+
+ Wraps awaitable (an object with __await__) into a coroutine
+ that will later be wrapped in a Task by ensure_future().
+ """
+ return (yield from awaitable.__await__())
class _GatheringFuture(futures.Future):
diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py
index 0426787..16d3d9d 100644
--- a/Lib/test/test_asyncio/test_tasks.py
+++ b/Lib/test/test_asyncio/test_tasks.py
@@ -153,6 +153,24 @@ class TaskTests(test_utils.TestCase):
t = asyncio.ensure_future(t_orig, loop=self.loop)
self.assertIs(t, t_orig)
+ @unittest.skipUnless(PY35, 'need python 3.5 or later')
+ def test_ensure_future_awaitable(self):
+ class Aw:
+ def __init__(self, coro):
+ self.coro = coro
+ def __await__(self):
+ return (yield from self.coro)
+
+ @asyncio.coroutine
+ def coro():
+ return 'ok'
+
+ loop = asyncio.new_event_loop()
+ self.set_event_loop(loop)
+ fut = asyncio.ensure_future(Aw(coro()), loop=loop)
+ loop.run_until_complete(fut)
+ assert fut.result() == 'ok'
+
def test_ensure_future_neither(self):
with self.assertRaises(TypeError):
asyncio.ensure_future('ok')
diff --git a/Misc/NEWS b/Misc/NEWS
index fcc9fe3..9a9b39b 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -152,6 +152,8 @@ Library
- Issue #23572: Fixed functools.singledispatch on classes with falsy
metaclasses. Patch by Ethan Furman.
+- asyncio: ensure_future() now accepts awaitable objects.
+
IDLE
----