diff options
author | Eli Bendersky <eliben@gmail.com> | 2012-01-03 04:26:13 (GMT) |
---|---|---|
committer | Eli Bendersky <eliben@gmail.com> | 2012-01-03 04:26:13 (GMT) |
commit | 74c503b40d9c40b1a5e7874188f36e067b14356c (patch) | |
tree | 98c491d186343d3a079621c16d3c5a6d08c1cd6f | |
parent | c041ab6c7d8fb6c32499c7adbe36bb9b48228c2c (diff) | |
download | cpython-74c503b40d9c40b1a5e7874188f36e067b14356c.zip cpython-74c503b40d9c40b1a5e7874188f36e067b14356c.tar.gz cpython-74c503b40d9c40b1a5e7874188f36e067b14356c.tar.bz2 |
use io.SEEK_* constants instead of os.SEEK_* where an IO stream is seeked, leaving the os.SEEK_* constants only for os.lseek, as documented
-rw-r--r-- | Lib/tarfile.py | 9 | ||||
-rw-r--r-- | Lib/test/test_fileio.py | 5 |
2 files changed, 8 insertions, 6 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py index 39dc1f1..427f132 100644 --- a/Lib/tarfile.py +++ b/Lib/tarfile.py @@ -40,6 +40,7 @@ __credits__ = "Gustavo Niemeyer, Niels Gust\u00e4bel, Richard Townsend." #--------- import sys import os +import io import shutil import stat import time @@ -833,20 +834,20 @@ class ExFileObject(object): return self.position - def seek(self, pos, whence=os.SEEK_SET): + def seek(self, pos, whence=io.SEEK_SET): """Seek to a position in the file. """ if self.closed: raise ValueError("I/O operation on closed file") - if whence == os.SEEK_SET: + if whence == io.SEEK_SET: self.position = min(max(pos, 0), self.size) - elif whence == os.SEEK_CUR: + elif whence == io.SEEK_CUR: if pos < 0: self.position = max(self.position + pos, 0) else: self.position = min(self.position + pos, self.size) - elif whence == os.SEEK_END: + elif whence == io.SEEK_END: self.position = max(min(self.size + pos, self.size), 0) else: raise ValueError("Invalid argument") diff --git a/Lib/test/test_fileio.py b/Lib/test/test_fileio.py index 103365d..75db82c 100644 --- a/Lib/test/test_fileio.py +++ b/Lib/test/test_fileio.py @@ -2,6 +2,7 @@ import sys import os +import io import errno import unittest from array import array @@ -334,10 +335,10 @@ class OtherFileTests(unittest.TestCase): self.assertEqual(f.tell(), 10) f.truncate(5) self.assertEqual(f.tell(), 10) - self.assertEqual(f.seek(0, os.SEEK_END), 5) + self.assertEqual(f.seek(0, io.SEEK_END), 5) f.truncate(15) self.assertEqual(f.tell(), 5) - self.assertEqual(f.seek(0, os.SEEK_END), 15) + self.assertEqual(f.seek(0, io.SEEK_END), 15) f.close() def testTruncateOnWindows(self): |