diff options
| author | Zackery Spytz <zspytz@gmail.com> | 2019-05-28 12:55:29 (GMT) |
|---|---|---|
| committer | Victor Stinner <vstinner@redhat.com> | 2019-05-28 12:55:28 (GMT) |
| commit | 05f16416d99dc9fc76fef11e56f16593e7a5955e (patch) | |
| tree | a440208f390b4c412ec28ceba4a508a6218a4075 | |
| parent | 04530812e90e45a37ed84e83505d63db7edc1262 (diff) | |
| download | cpython-05f16416d99dc9fc76fef11e56f16593e7a5955e.zip cpython-05f16416d99dc9fc76fef11e56f16593e7a5955e.tar.gz cpython-05f16416d99dc9fc76fef11e56f16593e7a5955e.tar.bz2 | |
bpo-26423: Fix possible overflow in wrap_lenfunc() (GH-13606)
Fix possible overflow in wrap_lenfunc() when
sizeof(long) < sizeof(Py_ssize_t) (e.g., 64-bit Windows).
| -rw-r--r-- | Lib/test/test_descr.py | 4 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Core and Builtins/2019-05-27-18-00-19.bpo-26423.RgUOE8.rst | 2 | ||||
| -rw-r--r-- | Objects/typeobject.c | 2 |
3 files changed, 7 insertions, 1 deletions
diff --git a/Lib/test/test_descr.py b/Lib/test/test_descr.py index e37a984..6b018cc 100644 --- a/Lib/test/test_descr.py +++ b/Lib/test/test_descr.py @@ -389,6 +389,10 @@ class OperatorsTest(unittest.TestCase): a.setstate(100) self.assertEqual(a.getstate(), 100) + def test_wrap_lenfunc_bad_cast(self): + self.assertEqual(range(sys.maxsize).__len__(), sys.maxsize) + + class ClassPropertiesAndMethods(unittest.TestCase): def assertHasAttr(self, obj, name): diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-05-27-18-00-19.bpo-26423.RgUOE8.rst b/Misc/NEWS.d/next/Core and Builtins/2019-05-27-18-00-19.bpo-26423.RgUOE8.rst new file mode 100644 index 0000000..6bf2031 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2019-05-27-18-00-19.bpo-26423.RgUOE8.rst @@ -0,0 +1,2 @@ +Fix possible overflow in ``wrap_lenfunc()`` when +``sizeof(long) < sizeof(Py_ssize_t)`` (e.g., 64-bit Windows). diff --git a/Objects/typeobject.c b/Objects/typeobject.c index 06e045b..c14cbad 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -5536,7 +5536,7 @@ wrap_lenfunc(PyObject *self, PyObject *args, void *wrapped) res = (*func)(self); if (res == -1 && PyErr_Occurred()) return NULL; - return PyLong_FromLong((long)res); + return PyLong_FromSsize_t(res); } static PyObject * |