summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2013-08-23 17:23:42 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2013-08-23 17:23:42 (GMT)
commita93c6db68bbb5070398b6cdb029a9bf0365846fc (patch)
tree9e807583a6cc0ee68e10985974a111ae548ce343
parent330cc52c99037eaabe0fcfa09f9b099743b0b913 (diff)
parent0c2dd0c0a9498422645a2805a955b9a898298bc6 (diff)
downloadcpython-a93c6db68bbb5070398b6cdb029a9bf0365846fc.zip
cpython-a93c6db68bbb5070398b6cdb029a9bf0365846fc.tar.gz
cpython-a93c6db68bbb5070398b6cdb029a9bf0365846fc.tar.bz2
(Merge 3.3) Close #17702: On error, os.environb now removes suppress the except
context when raising a new KeyError with the original key.
-rw-r--r--Lib/os.py4
-rw-r--r--Lib/test/test_os.py3
-rw-r--r--Misc/NEWS3
3 files changed, 8 insertions, 2 deletions
diff --git a/Lib/os.py b/Lib/os.py
index 96720e4..5fde360 100644
--- a/Lib/os.py
+++ b/Lib/os.py
@@ -648,7 +648,7 @@ class _Environ(MutableMapping):
value = self._data[self.encodekey(key)]
except KeyError:
# raise KeyError with the original key value
- raise KeyError(key)
+ raise KeyError(key) from None
return self.decodevalue(value)
def __setitem__(self, key, value):
@@ -664,7 +664,7 @@ class _Environ(MutableMapping):
del self._data[encodedkey]
except KeyError:
# raise KeyError with the original key value
- raise KeyError(key)
+ raise KeyError(key) from None
def __iter__(self):
for key in self._data:
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index b7796b5..a4be0bb 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -646,10 +646,13 @@ class EnvironTests(mapping_tests.BasicTestMappingProtocol):
with self.assertRaises(KeyError) as cm:
os.environ[missing]
self.assertIs(cm.exception.args[0], missing)
+ self.assertTrue(cm.exception.__suppress_context__)
with self.assertRaises(KeyError) as cm:
del os.environ[missing]
self.assertIs(cm.exception.args[0], missing)
+ self.assertTrue(cm.exception.__suppress_context__)
+
class WalkTests(unittest.TestCase):
"""Tests for os.walk()."""
diff --git a/Misc/NEWS b/Misc/NEWS
index 7b62d16..431674a 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -38,6 +38,9 @@ Core and Builtins
Library
-------
+- Issue #17702: On error, os.environb now removes suppress the except context
+ when raising a new KeyError with the original key.
+
- Issue #16809: Fixed some tkinter incompabilities with Tcl/Tk 8.6.
- Issue #16809: Tkinter's splitlist() and split() methods now accept Tcl_Obj