summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@redhat.com>2018-09-25 15:30:15 (GMT)
committerGitHub <noreply@github.com>2018-09-25 15:30:15 (GMT)
commit46f40be8b907854deb81c6132b7cb038e9e5202a (patch)
treeb5bc41943690a77d4d5eeddae87562535fc2fd02
parent6ea29c5e90dde6c240bd8e0815614b52ac307ea1 (diff)
downloadcpython-46f40be8b907854deb81c6132b7cb038e9e5202a.zip
cpython-46f40be8b907854deb81c6132b7cb038e9e5202a.tar.gz
cpython-46f40be8b907854deb81c6132b7cb038e9e5202a.tar.bz2
bpo-33937: Catch ENOMEM error in test_socket (#9557)
Fix test_socket.SendmsgSCTPStreamTest: catch ENOMEM error. testSendmsgTimeout() and testSendmsgDontWait() randomly fail on Travis CI with: "OSError: [Errno 12] Cannot allocate memory".
-rw-r--r--Lib/test/test_socket.py15
1 files changed, 13 insertions, 2 deletions
diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index f4d58eb..bd4fad1 100644
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -2616,9 +2616,18 @@ class SendmsgStreamTests(SendmsgTests):
def _testSendmsgTimeout(self):
try:
self.cli_sock.settimeout(0.03)
- with self.assertRaises(socket.timeout):
+ try:
while True:
self.sendmsgToServer([b"a"*512])
+ except socket.timeout:
+ pass
+ except OSError as exc:
+ if exc.errno != errno.ENOMEM:
+ raise
+ # bpo-33937 the test randomly fails on Travis CI with
+ # "OSError: [Errno 12] Cannot allocate memory"
+ else:
+ self.fail("socket.timeout not raised")
finally:
self.misc_event.set()
@@ -2641,8 +2650,10 @@ class SendmsgStreamTests(SendmsgTests):
with self.assertRaises(OSError) as cm:
while True:
self.sendmsgToServer([b"a"*512], [], socket.MSG_DONTWAIT)
+ # bpo-33937: catch also ENOMEM, the test randomly fails on Travis CI
+ # with "OSError: [Errno 12] Cannot allocate memory"
self.assertIn(cm.exception.errno,
- (errno.EAGAIN, errno.EWOULDBLOCK))
+ (errno.EAGAIN, errno.EWOULDBLOCK, errno.ENOMEM))
finally:
self.misc_event.set()