summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaymond Hettinger <python@rcn.com>2016-09-08 21:45:40 (GMT)
committerRaymond Hettinger <python@rcn.com>2016-09-08 21:45:40 (GMT)
commit4c483ad52b6f7760a0a861badae6c803d6ce8590 (patch)
treeb4a4883562a12fc4accd126e967b840ff1518bb0
parent33df0c3fb6c48a0434f407732d2a50102923db51 (diff)
downloadcpython-4c483ad52b6f7760a0a861badae6c803d6ce8590.zip
cpython-4c483ad52b6f7760a0a861badae6c803d6ce8590.tar.gz
cpython-4c483ad52b6f7760a0a861badae6c803d6ce8590.tar.bz2
Merge
-rw-r--r--Lib/test/test_set.py15
-rw-r--r--Python/ceval.c6
2 files changed, 19 insertions, 2 deletions
diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
index 49abfb3..afa6e7f 100644
--- a/Lib/test/test_set.py
+++ b/Lib/test/test_set.py
@@ -389,6 +389,21 @@ class TestSet(TestJointOps, unittest.TestCase):
t = {1,2,3}
self.assertEqual(s, t)
+ def test_set_literal_insertion_order(self):
+ # SF Issue #26020 -- Expect left to right insertion
+ s = {1, 1.0, True}
+ self.assertEqual(len(s), 1)
+ stored_value = s.pop()
+ self.assertEqual(type(stored_value), int)
+
+ def test_set_literal_evaluation_order(self):
+ # Expect left to right expression evaluation
+ events = []
+ def record(obj):
+ events.append(obj)
+ s = {record(1), record(2), record(3)}
+ self.assertEqual(events, [1, 2, 3])
+
def test_hash(self):
self.assertRaises(TypeError, hash, self.s)
diff --git a/Python/ceval.c b/Python/ceval.c
index 9109ea5..0c3ef7b 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -2619,14 +2619,16 @@ _PyEval_EvalFrameDefault(PyFrameObject *f, int throwflag)
TARGET(BUILD_SET) {
PyObject *set = PySet_New(NULL);
int err = 0;
+ int i;
if (set == NULL)
goto error;
- while (--oparg >= 0) {
- PyObject *item = POP();
+ for (i = oparg; i > 0; i--) {
+ PyObject *item = PEEK(i);
if (err == 0)
err = PySet_Add(set, item);
Py_DECREF(item);
}
+ STACKADJ(-oparg);
if (err != 0) {
Py_DECREF(set);
goto error;