diff options
| author | t k <tahia.khan@gmail.com> | 2019-09-19 13:34:41 (GMT) |
|---|---|---|
| committer | Paul Ganssle <paul@ganssle.io> | 2019-09-19 13:34:41 (GMT) |
| commit | 96b1c59c71534db3f0f3799cd84e2006923a5098 (patch) | |
| tree | 58abb7680d3a72a0388cf643546f6c099af122a0 | |
| parent | 9fdc64cf1266b6d5bf0503847b5c38e5edc53a14 (diff) | |
| download | cpython-96b1c59c71534db3f0f3799cd84e2006923a5098.zip cpython-96b1c59c71534db3f0f3799cd84e2006923a5098.tar.gz cpython-96b1c59c71534db3f0f3799cd84e2006923a5098.tar.bz2 | |
bpo-38155: Add __all__ to datetime module (GH-16203)
https://bugs.python.org/issue38155
| -rw-r--r-- | Lib/datetime.py | 4 | ||||
| -rw-r--r-- | Lib/test/datetimetester.py | 6 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Library/2019-09-16-21-47-48.bpo-38155.d92lRc.rst | 1 |
3 files changed, 11 insertions, 0 deletions
diff --git a/Lib/datetime.py b/Lib/datetime.py index 0adf1dd..6755519 100644 --- a/Lib/datetime.py +++ b/Lib/datetime.py @@ -4,6 +4,10 @@ See http://www.iana.org/time-zones/repository/tz-link.html for time zone and DST data sources. """ +__all__ = ("date", "datetime", "time", "timedelta", "timezone", "tzinfo", + "MINYEAR", "MAXYEAR") + + import time as _time import math as _math import sys diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py index 32977b1..42e2cec 100644 --- a/Lib/test/datetimetester.py +++ b/Lib/test/datetimetester.py @@ -62,6 +62,12 @@ class TestModule(unittest.TestCase): self.assertEqual(datetime.MINYEAR, 1) self.assertEqual(datetime.MAXYEAR, 9999) + def test_all(self): + """Test that __all__ only points to valid attributes.""" + all_attrs = dir(datetime_module) + for attr in datetime_module.__all__: + self.assertIn(attr, all_attrs) + def test_name_cleanup(self): if '_Pure' in self.__class__.__name__: self.skipTest('Only run for Fast C implementation') diff --git a/Misc/NEWS.d/next/Library/2019-09-16-21-47-48.bpo-38155.d92lRc.rst b/Misc/NEWS.d/next/Library/2019-09-16-21-47-48.bpo-38155.d92lRc.rst new file mode 100644 index 0000000..14b6e2d --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-09-16-21-47-48.bpo-38155.d92lRc.rst @@ -0,0 +1 @@ +Add ``__all__`` to :mod:`datetime`. Patch by Tahia Khan. |