diff options
| author | Neal Norwitz <nnorwitz@gmail.com> | 2007-08-12 17:21:38 (GMT) |
|---|---|---|
| committer | Neal Norwitz <nnorwitz@gmail.com> | 2007-08-12 17:21:38 (GMT) |
| commit | ab40b30398920884fff8ca1c5f89bf54ad8ae0bf (patch) | |
| tree | d8b9191d35bbc7ba55ca669afc29bbde12ead346 | |
| parent | cda5c068a460c29dab3a24abcfcc55a200ce77b3 (diff) | |
| download | cpython-ab40b30398920884fff8ca1c5f89bf54ad8ae0bf.zip cpython-ab40b30398920884fff8ca1c5f89bf54ad8ae0bf.tar.gz cpython-ab40b30398920884fff8ca1c5f89bf54ad8ae0bf.tar.bz2 | |
Add comment that should be addressed
| -rw-r--r-- | Objects/unicodeobject.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 6b27adb..47109a5 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -1188,6 +1188,9 @@ PyObject *_PyUnicode_AsDefaultEncodedString(PyObject *unicode, return v; if (errors != NULL) Py_FatalError("non-NULL encoding in _PyUnicode_AsDefaultEncodedString"); + /* XXX(nnorwitz): errors will always be NULL due to the check above. + Should this check and the else be removed since it's dead code? + */ if (errors == NULL) { b = PyUnicode_EncodeUTF8(PyUnicode_AS_UNICODE(unicode), PyUnicode_GET_SIZE(unicode), |