diff options
| author | Nick Coghlan <ncoghlan@gmail.com> | 2017-02-18 09:31:22 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-18 09:31:22 (GMT) |
| commit | ace5c0fdd9b962e6e886c29dbcea72c53f051dc4 (patch) | |
| tree | 42ccb556dbc142665c461cd02d76b4ad5dbfd1d6 | |
| parent | 1b3d88eb33085e90af729c4c2f78b5ba1b942b1e (diff) | |
| download | cpython-ace5c0fdd9b962e6e886c29dbcea72c53f051dc4.zip cpython-ace5c0fdd9b962e6e886c29dbcea72c53f051dc4.tar.gz cpython-ace5c0fdd9b962e6e886c29dbcea72c53f051dc4.tar.bz2 | |
bpo-29571: Use correct locale encoding in test_re (#149)
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).
``re.LOCALE`` uses the latter, so update the test case to match.
| -rw-r--r-- | Lib/test/test_re.py | 2 | ||||
| -rw-r--r-- | Misc/NEWS | 5 |
2 files changed, 6 insertions, 1 deletions
diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py index 1d7fb76..92d2c13 100644 --- a/Lib/test/test_re.py +++ b/Lib/test/test_re.py @@ -1399,7 +1399,7 @@ class ReTests(unittest.TestCase): def test_locale_flag(self): import locale - _, enc = locale.getlocale(locale.LC_CTYPE) + enc = locale.getpreferredencoding(False) # Search non-ASCII letter for i in range(128, 256): try: @@ -801,6 +801,11 @@ Tools/Demos Tests ----- +- Issue #29571: to match the behaviour of the ``re.LOCALE`` flag, + test_re.test_locale_flag now uses ``locale.getpreferredencoding(False)`` to + determine the candidate encoding for the test regex (allowing it to correctly + skip the test when the default locale encoding is a multi-byte encoding) + - Issue #24932: Use proper command line parsing in _testembed - Issue #28950: Disallow -j0 to be combined with -T/-l in regrtest |