diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2020-06-12 17:02:45 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-12 17:02:45 (GMT) |
| commit | ee3f7fee94915ab4f34c92d6c89b211de476660d (patch) | |
| tree | 37e501199c16e43f1a4b868c41e89953edd8f476 | |
| parent | 2c0a59bb3d2fb83312c965ea9d5ef9d0028a53bb (diff) | |
| download | cpython-ee3f7fee94915ab4f34c92d6c89b211de476660d.zip cpython-ee3f7fee94915ab4f34c92d6c89b211de476660d.tar.gz cpython-ee3f7fee94915ab4f34c92d6c89b211de476660d.tar.bz2 | |
bpo-40955: Fix memory leak in subprocess module (GH-20825)
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
GH-0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
GH-1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
GH-2 0xe0305b in cfunction_call Objects/methodobject.c:546
```
Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 0d3350daa8123a3e16d4a534b6e873eb12c10d7c)
Co-authored-by: Christian Heimes <christian@python.org>
| -rw-r--r-- | Misc/NEWS.d/next/Library/2020-06-12-11-55-30.bpo-40955.huixCg.rst | 1 | ||||
| -rw-r--r-- | Modules/_posixsubprocess.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Library/2020-06-12-11-55-30.bpo-40955.huixCg.rst b/Misc/NEWS.d/next/Library/2020-06-12-11-55-30.bpo-40955.huixCg.rst new file mode 100644 index 0000000..9a98030 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-06-12-11-55-30.bpo-40955.huixCg.rst @@ -0,0 +1 @@ +Fix a minor memory leak in :mod:`subprocess` module when extra_groups was specified. diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c index add2962..5d1691a 100644 --- a/Modules/_posixsubprocess.c +++ b/Modules/_posixsubprocess.c @@ -893,6 +893,7 @@ subprocess_fork_exec(PyObject* self, PyObject *args) if (_enable_gc(need_to_reenable_gc, gc_module)) { pid = -1; } + PyMem_RawFree(groups); Py_XDECREF(preexec_fn_args_tuple); Py_XDECREF(gc_module); |