diff options
| author | Miss Skeleton (bot) <31488909+miss-islington@users.noreply.github.com> | 2020-10-05 16:49:41 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-05 16:49:41 (GMT) |
| commit | 10b4136bfa5878c058753e1d1bd091e0f7e1ba40 (patch) | |
| tree | e23118379ba8ba2172e9eb1905ec2f4ffa159a38 | |
| parent | 1691435fe7e369083c6e8c4a55786dc9c6448a29 (diff) | |
| download | cpython-10b4136bfa5878c058753e1d1bd091e0f7e1ba40.zip cpython-10b4136bfa5878c058753e1d1bd091e0f7e1ba40.tar.gz cpython-10b4136bfa5878c058753e1d1bd091e0f7e1ba40.tar.bz2 | |
bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) (#22567)
Call urllib.request.urlcleanup() to reset the global
urllib.request._opener.
(cherry picked from commit 1fce240d6c4b2b2cc17a86e88c65169e15b9feeb)
Co-authored-by: Victor Stinner <vstinner@python.org>
| -rw-r--r-- | Lib/test/test_site.py | 2 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst | 3 |
2 files changed, 5 insertions, 0 deletions
diff --git a/Lib/test/test_site.py b/Lib/test/test_site.py index 923f35e..ece6a07 100644 --- a/Lib/test/test_site.py +++ b/Lib/test/test_site.py @@ -509,6 +509,8 @@ class ImportSideEffectTests(unittest.TestCase): # string displayed by license in the absence of a LICENSE file. url = license._Printer__data.split()[1] req = urllib.request.Request(url, method='HEAD') + # Reset global urllib.request._opener + self.addCleanup(urllib.request.urlcleanup) try: with socket_helper.transient_internet(url): with urllib.request.urlopen(req) as data: diff --git a/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst b/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst new file mode 100644 index 0000000..e58ad26 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2020-10-05-09-37-43.bpo-41939.P4OlbA.rst @@ -0,0 +1,3 @@ +Fix test_site.test_license_exists_at_url(): call +``urllib.request.urlcleanup()`` to reset the global +``urllib.request._opener``. Patch by Victor Stinner. |