diff options
author | Senthil Kumaran <senthil@uthcode.com> | 2011-08-02 10:34:53 (GMT) |
---|---|---|
committer | Senthil Kumaran <senthil@uthcode.com> | 2011-08-02 10:34:53 (GMT) |
commit | d61535d50b66a68cc9aecebbf5faca26d7b60a28 (patch) | |
tree | 0faef08de4cf96b597157165ab14146ebd1331d0 | |
parent | 328b5015a2a1c5b56ac633fa7980a361db64a016 (diff) | |
parent | eb71ad4c71a95d9b7397e3baaaadcb0687efa894 (diff) | |
download | cpython-d61535d50b66a68cc9aecebbf5faca26d7b60a28.zip cpython-d61535d50b66a68cc9aecebbf5faca26d7b60a28.tar.gz cpython-d61535d50b66a68cc9aecebbf5faca26d7b60a28.tar.bz2 |
Fix closes Issue12676 - Invalid identifier used in TypeError message in http.client.
Reported by Popa Claudiu and Patch by Santoso Wijaya.
-rw-r--r-- | Lib/http/client.py | 2 | ||||
-rw-r--r-- | Lib/test/test_httplib.py | 7 |
2 files changed, 8 insertions, 1 deletions
diff --git a/Lib/http/client.py b/Lib/http/client.py index 2e68b3c..82213c3 100644 --- a/Lib/http/client.py +++ b/Lib/http/client.py @@ -778,7 +778,7 @@ class HTTPConnection: self.sock.sendall(d) else: raise TypeError("data should be a bytes-like object\ - or an iterable, got %r " % type(it)) + or an iterable, got %r " % type(data)) def _output(self, s): """Add a line of output to the current request buffer. diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py index 890b1b9..ce9e346 100644 --- a/Lib/test/test_httplib.py +++ b/Lib/test/test_httplib.py @@ -246,6 +246,13 @@ class BasicTest(TestCase): conn.request('GET', '/foo', body(), {'Content-Length': '11'}) self.assertEqual(sock.data, expected) + def test_send_type_error(self): + # See: Issue #12676 + conn = client.HTTPConnection('example.com') + conn.sock = FakeSocket('') + with self.assertRaises(TypeError): + conn.request('POST', 'test', conn) + def test_chunked(self): chunked_start = ( 'HTTP/1.1 200 OK\r\n' |