summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKarthikeyan Singaravelan <tir.karthi@gmail.com>2021-04-12 18:17:25 (GMT)
committerGitHub <noreply@github.com>2021-04-12 18:17:25 (GMT)
commita9cf69df2e031d6157f01289f66ca9cf723ceb5c (patch)
tree10b37ae2e40dceb13f0725ac6d52d49ac3dc08ff
parent852150ddfe68bc2696fc880175aeb855a0c16ae6 (diff)
downloadcpython-a9cf69df2e031d6157f01289f66ca9cf723ceb5c.zip
cpython-a9cf69df2e031d6157f01289f66ca9cf723ceb5c.tar.gz
cpython-a9cf69df2e031d6157f01289f66ca9cf723ceb5c.tar.bz2
bpo-41515: Fix KeyError raised in get_type_hints (GH-25352)
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com> Co-authored-by: efahl <36704995+efahl@users.noreply.github.com>
-rw-r--r--Lib/test/test_typing.py6
-rw-r--r--Lib/typing.py5
-rw-r--r--Misc/NEWS.d/next/Library/2021-04-12-06-01-10.bpo-41515.YaVReb.rst2
3 files changed, 12 insertions, 1 deletions
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index 062163c..a6afd35 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -2267,6 +2267,12 @@ class ClassVarTests(BaseTestCase):
with self.assertRaises(TypeError):
issubclass(int, ClassVar)
+ def test_bad_module(self):
+ # bpo-41515
+ class BadModule:
+ pass
+ BadModule.__module__ = 'bad' # Something not in sys.modules
+ assert(get_type_hints(BadModule), {})
class FinalTests(BaseTestCase):
diff --git a/Lib/typing.py b/Lib/typing.py
index 583438e..dc2a7a4 100644
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -1628,7 +1628,10 @@ def get_type_hints(obj, globalns=None, localns=None, include_extras=False):
hints = {}
for base in reversed(obj.__mro__):
if globalns is None:
- base_globals = sys.modules[base.__module__].__dict__
+ try:
+ base_globals = sys.modules[base.__module__].__dict__
+ except KeyError:
+ continue
else:
base_globals = globalns
ann = base.__dict__.get('__annotations__', {})
diff --git a/Misc/NEWS.d/next/Library/2021-04-12-06-01-10.bpo-41515.YaVReb.rst b/Misc/NEWS.d/next/Library/2021-04-12-06-01-10.bpo-41515.YaVReb.rst
new file mode 100644
index 0000000..aef5c17
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2021-04-12-06-01-10.bpo-41515.YaVReb.rst
@@ -0,0 +1,2 @@
+Fix :exc:`KeyError` raised in :func:`typing.get_type_hints` due to
+synthetic modules that don't appear in ``sys.modules``.