summaryrefslogtreecommitdiffstats
path: root/Doc/distutils
diff options
context:
space:
mode:
authorRuslan Kuprieiev <kupruser@gmail.com>2019-06-28 16:12:16 (GMT)
committerVictor Stinner <vstinner@redhat.com>2019-06-28 16:12:16 (GMT)
commit042821ae3cf537e01963c9ec85d1a454d921e826 (patch)
tree7a4372205aa96a3f6f26e9cfb59e274a468574c8 /Doc/distutils
parent64580da33122a10aef75c76aa3ff87c0ee11e3d7 (diff)
downloadcpython-042821ae3cf537e01963c9ec85d1a454d921e826.zip
cpython-042821ae3cf537e01963c9ec85d1a454d921e826.tar.gz
cpython-042821ae3cf537e01963c9ec85d1a454d921e826.tar.bz2
bpo-37380: subprocess: don't use _active on win (GH-14360)
As noted by @eryksun in [1] and [2], using _cleanup and _active(in __del__) is not necessary on Windows, since: > Unlike Unix, a process in Windows doesn't have to be waited on by > its parent to avoid a zombie. Keeping the handle open will actually > create a zombie until the next _cleanup() call, which may be never > if Popen() isn't called again. This patch simply defines `subprocess._active` as `None`, for which we already have the proper logic in place in `subprocess.Popen.__del__`, that prevents it from trying to append the process to the `_active`. This patch also defines `subprocess._cleanup` as a noop for Windows. [1] https://bugs.python.org/issue37380#msg346333 [2] https://bugs.python.org/issue36067#msg336262 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai>
Diffstat (limited to 'Doc/distutils')
0 files changed, 0 insertions, 0 deletions