diff options
author | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2008-02-16 14:34:57 (GMT) |
---|---|---|
committer | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2008-02-16 14:34:57 (GMT) |
commit | 588ff93f1383436694e26c962528291913012296 (patch) | |
tree | 21b15b95feb36e0042c50be5ff650e002c66d30e /Doc/documenting | |
parent | 943321d586f3ce1d084995c66fe85137d8b8ebf8 (diff) | |
download | cpython-588ff93f1383436694e26c962528291913012296.zip cpython-588ff93f1383436694e26c962528291913012296.tar.gz cpython-588ff93f1383436694e26c962528291913012296.tar.bz2 |
Crashers of the day: Py_CLEAR must be used when there is a chance that the
function can be called recursively.
This was discussed in issue1020188.
In python codebase, all occurrences of Py_[X]DECREF(xxx->yyy) are suspect,
except when they appear in tp_new or tp_dealloc functions, or when
the member cannot be of a user-defined class.
Note that tp_init is not safe.
I do have a (crashing) example for every changed line.
Is it worth adding them to the test suite?
Example:
class SpecialStr(str):
def __del__(self):
s.close()
import cStringIO
s = cStringIO.StringIO(SpecialStr("text"))
s.close() # Segfault
Diffstat (limited to 'Doc/documenting')
0 files changed, 0 insertions, 0 deletions