summaryrefslogtreecommitdiffstats
path: root/Grammar
diff options
context:
space:
mode:
authorNikita Sobolev <mail@sobolevn.me>2024-05-07 12:01:06 (GMT)
committerGitHub <noreply@github.com>2024-05-07 12:01:06 (GMT)
commitb60d4c0d53b6aafbf4a6e560b4cb6f1d5c7240c8 (patch)
tree54765a43707335c5c8d3656098e3a4acbfe0bb3f /Grammar
parent04859228aa11756558807bcf99ccff78e4e8c56d (diff)
downloadcpython-b60d4c0d53b6aafbf4a6e560b4cb6f1d5c7240c8.zip
cpython-b60d4c0d53b6aafbf4a6e560b4cb6f1d5c7240c8.tar.gz
cpython-b60d4c0d53b6aafbf4a6e560b4cb6f1d5c7240c8.tar.bz2
gh-118090: Improve error message for empty type param brackets (GH-118091)
Diffstat (limited to 'Grammar')
-rw-r--r--Grammar/python.gram15
1 files changed, 12 insertions, 3 deletions
diff --git a/Grammar/python.gram b/Grammar/python.gram
index 1c1c53c..c04bc64 100644
--- a/Grammar/python.gram
+++ b/Grammar/python.gram
@@ -269,11 +269,11 @@ function_def[stmt_ty]:
function_def_raw[stmt_ty]:
| invalid_def_raw
- | 'def' n=NAME t=[type_params] &&'(' params=[params] ')' a=['->' z=expression { z }] &&':' tc=[func_type_comment] b=block {
+ | 'def' n=NAME t=[type_params] '(' params=[params] ')' a=['->' z=expression { z }] ':' tc=[func_type_comment] b=block {
_PyAST_FunctionDef(n->v.Name.id,
(params) ? params : CHECK(arguments_ty, _PyPegen_empty_arguments(p)),
b, NULL, a, NEW_TYPE_COMMENT(p, tc), t, EXTRA) }
- | 'async' 'def' n=NAME t=[type_params] &&'(' params=[params] ')' a=['->' z=expression { z }] &&':' tc=[func_type_comment] b=block {
+ | 'async' 'def' n=NAME t=[type_params] '(' params=[params] ')' a=['->' z=expression { z }] ':' tc=[func_type_comment] b=block {
CHECK_VERSION(
stmt_ty,
5,
@@ -641,7 +641,9 @@ type_alias[stmt_ty]:
# Type parameter declaration
# --------------------------
-type_params[asdl_type_param_seq*]: '[' t=type_param_seq ']' {
+type_params[asdl_type_param_seq*]:
+ | invalid_type_params
+ | '[' t=type_param_seq ']' {
CHECK_VERSION(asdl_type_param_seq *, 12, "Type parameter lists are", t) }
type_param_seq[asdl_type_param_seq*]: a[asdl_type_param_seq*]=','.type_param+ [','] { a }
@@ -1392,6 +1394,7 @@ invalid_for_stmt:
invalid_def_raw:
| ['async'] a='def' NAME [type_params] '(' [params] ')' ['->' expression] ':' NEWLINE !INDENT {
RAISE_INDENTATION_ERROR("expected an indented block after function definition on line %d", a->lineno) }
+ | ['async'] 'def' NAME [type_params] &&'(' [params] ')' ['->' expression] &&':' [func_type_comment] block
invalid_class_def_raw:
| 'class' NAME [type_params] ['(' [arguments] ')'] NEWLINE { RAISE_SYNTAX_ERROR("expected ':'") }
| a='class' NAME [type_params] ['(' [arguments] ')'] ':' NEWLINE !INDENT {
@@ -1435,3 +1438,9 @@ invalid_arithmetic:
| sum ('+'|'-'|'*'|'/'|'%'|'//'|'@') a='not' b=inversion { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "'not' after an operator must be parenthesized") }
invalid_factor:
| ('+' | '-' | '~') a='not' b=factor { RAISE_SYNTAX_ERROR_KNOWN_RANGE(a, b, "'not' after an operator must be parenthesized") }
+
+invalid_type_params:
+ | '[' token=']' {
+ RAISE_SYNTAX_ERROR_STARTING_FROM(
+ token,
+ "Type parameter list cannot be empty")}