diff options
author | Jamie Davis <davisjam@vt.edu> | 2018-03-04 05:33:32 (GMT) |
---|---|---|
committer | Benjamin Peterson <benjamin@python.org> | 2018-03-04 05:33:32 (GMT) |
commit | 0e6c8ee2358a2e23117501826c008842acb835ac (patch) | |
tree | e430b938abc09f1a5bb9613f11c60e575a9e2865 /Include/pylifecycle.h | |
parent | 13cfd57dcf58485d6242fd8118c6ea4b10e29aab (diff) | |
download | cpython-0e6c8ee2358a2e23117501826c008842acb835ac.zip cpython-0e6c8ee2358a2e23117501826c008842acb835ac.tar.gz cpython-0e6c8ee2358a2e23117501826c008842acb835ac.tar.bz2 |
bpo-32981: Fix catastrophic backtracking vulns (#5955)
* Prevent low-grade poplib REDOS (CVE-2018-1060)
The regex to test a mail server's timestamp is susceptible to
catastrophic backtracking on long evil responses from the server.
Happily, the maximum length of malicious inputs is 2K thanks
to a limit introduced in the fix for CVE-2013-1752.
A 2KB evil response from the mail server would result in small slowdowns
(milliseconds vs. microseconds) accumulated over many apop calls.
This is a potential DOS vector via accumulated slowdowns.
Replace it with a similar non-vulnerable regex.
The new regex is RFC compliant.
The old regex was non-compliant in edge cases.
* Prevent difflib REDOS (CVE-2018-1061)
The default regex for IS_LINE_JUNK is susceptible to
catastrophic backtracking.
This is a potential DOS vector.
Replace it with an equivalent non-vulnerable regex.
Also introduce unit and REDOS tests for difflib.
Co-authored-by: Tim Peters <tim.peters@gmail.com>
Co-authored-by: Christian Heimes <christian@python.org>
Diffstat (limited to 'Include/pylifecycle.h')
0 files changed, 0 insertions, 0 deletions