diff options
| author | Fred Drake <fdrake@acm.org> | 2000-06-29 19:17:04 (GMT) |
|---|---|---|
| committer | Fred Drake <fdrake@acm.org> | 2000-06-29 19:17:04 (GMT) |
| commit | 13634cf7a407202777285172a57cfcddb20a2047 (patch) | |
| tree | 6cb9ea5a8fbe00548224ee45e04ca3bc1daff715 /Include | |
| parent | b46696c0ed640992b4524aab888a26a56d993142 (diff) | |
| download | cpython-13634cf7a407202777285172a57cfcddb20a2047.zip cpython-13634cf7a407202777285172a57cfcddb20a2047.tar.gz cpython-13634cf7a407202777285172a57cfcddb20a2047.tar.bz2 | |
This patch addresses two main issues: (1) There exist some non-fatal
errors in some of the hash algorithms. For exmaple, in float_hash and
complex_hash a certain part of the value is not included in the hash
calculation. See Tim's, Guido's, and my discussion of this on
python-dev in May under the title "fix float_hash and complex_hash for
64-bit *nix"
(2) The hash algorithms that use pointers (e.g. func_hash, code_hash)
are universally not correct on Win64 (they assume that sizeof(long) ==
sizeof(void*))
As well, this patch significantly cleans up the hash code. It adds the
two function _Py_HashDouble and _PyHash_VoidPtr that the various
hashing routine are changed to use.
These help maintain the hash function invariant: (a==b) =>
(hash(a)==hash(b))) I have added Lib/test/test_hash.py and
Lib/test/output/test_hash to test this for some cases.
Diffstat (limited to 'Include')
| -rw-r--r-- | Include/object.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Include/object.h b/Include/object.h index 2250b7f..20757be 100644 --- a/Include/object.h +++ b/Include/object.h @@ -293,6 +293,10 @@ extern DL_IMPORT(void) Py_ReprLeave Py_PROTO((PyObject *)); /* tstate dict key for PyObject_Compare helper */ extern PyObject *_PyCompareState_Key; +/* Helpers for hash functions */ +extern DL_IMPORT(long) _Py_HashDouble Py_PROTO((double)); +extern DL_IMPORT(long) _Py_HashPointer Py_PROTO((void*)); + /* Flag bits for printing: */ #define Py_PRINT_RAW 1 /* No string quotes etc. */ |