diff options
author | Antoine Pitrou <solipsis@pitrou.net> | 2009-11-05 13:42:29 (GMT) |
---|---|---|
committer | Antoine Pitrou <solipsis@pitrou.net> | 2009-11-05 13:42:29 (GMT) |
commit | 99c160b559dc6c510e2e9f713191c3c80e26c6f2 (patch) | |
tree | 9b67f288cf29af2f7877bee0a99807c2a3778c18 /Lib/_threading_local.py | |
parent | 2537e7a443bb1903cc79995d152b594264ff33d8 (diff) | |
download | cpython-99c160b559dc6c510e2e9f713191c3c80e26c6f2.zip cpython-99c160b559dc6c510e2e9f713191c3c80e26c6f2.tar.gz cpython-99c160b559dc6c510e2e9f713191c3c80e26c6f2.tar.bz2 |
Issue #7264: Fix a possible deadlock when deallocating thread-local objects
which are part of a reference cycle.
Diffstat (limited to 'Lib/_threading_local.py')
-rw-r--r-- | Lib/_threading_local.py | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/Lib/_threading_local.py b/Lib/_threading_local.py index 4eda630..243d84e 100644 --- a/Lib/_threading_local.py +++ b/Lib/_threading_local.py @@ -218,10 +218,12 @@ class local(_localbase): key = object.__getattribute__(self, '_local__key') try: - threads = list(threading.enumerate()) + # We use the non-locking API since we might already hold the lock + # (__del__ can be called at any point by the cyclic GC). + threads = threading._enumerate() except: - # If enumerate fails, as it seems to do during - # shutdown, we'll skip cleanup under the assumption + # If enumerating the current threads fails, as it seems to do + # during shutdown, we'll skip cleanup under the assumption # that there is nothing to clean up. return |