summaryrefslogtreecommitdiffstats
path: root/Lib/asyncio/locks.py
diff options
context:
space:
mode:
authorMathieu Sornay <msornay@users.noreply.github.com>2017-06-09 20:17:40 (GMT)
committerYury Selivanov <yury@magic.io>2017-06-09 20:17:40 (GMT)
commit894a654a9caafb7a5bf63e1383a048041c05023b (patch)
treecf58d85a6cd3ad47138b2b6d6fa7c07a2ccbbcbb /Lib/asyncio/locks.py
parentf9f1ccace395a8f65b60dc12567a237b4002fd18 (diff)
downloadcpython-894a654a9caafb7a5bf63e1383a048041c05023b.zip
cpython-894a654a9caafb7a5bf63e1383a048041c05023b.tar.gz
cpython-894a654a9caafb7a5bf63e1383a048041c05023b.tar.bz2
Fix waiter cancellation in asyncio.Lock (#1031)
Avoid a deadlock when the waiter who is about to take the lock is cancelled Issue #27585
Diffstat (limited to 'Lib/asyncio/locks.py')
-rw-r--r--Lib/asyncio/locks.py17
1 files changed, 12 insertions, 5 deletions
diff --git a/Lib/asyncio/locks.py b/Lib/asyncio/locks.py
index deefc93..9266183 100644
--- a/Lib/asyncio/locks.py
+++ b/Lib/asyncio/locks.py
@@ -176,6 +176,10 @@ class Lock(_ContextManagerMixin):
yield from fut
self._locked = True
return True
+ except futures.CancelledError:
+ if not self._locked:
+ self._wake_up_first()
+ raise
finally:
self._waiters.remove(fut)
@@ -192,14 +196,17 @@ class Lock(_ContextManagerMixin):
"""
if self._locked:
self._locked = False
- # Wake up the first waiter who isn't cancelled.
- for fut in self._waiters:
- if not fut.done():
- fut.set_result(True)
- break
+ self._wake_up_first()
else:
raise RuntimeError('Lock is not acquired.')
+ def _wake_up_first(self):
+ """Wake up the first waiter who isn't cancelled."""
+ for fut in self._waiters:
+ if not fut.done():
+ fut.set_result(True)
+ break
+
class Event:
"""Asynchronous equivalent to threading.Event.