summaryrefslogtreecommitdiffstats
path: root/Lib/asyncio/selector_events.py
diff options
context:
space:
mode:
authorGuido van Rossum <guido@python.org>2014-05-06 21:42:40 (GMT)
committerGuido van Rossum <guido@python.org>2014-05-06 21:42:40 (GMT)
commit3d139d8ed6712f39f4e91dc084ed421b76af09ae (patch)
treeba711bde2328d996b11330331e5797afde744bb1 /Lib/asyncio/selector_events.py
parent9fafc9f79a0510cd7f7357fcbb8cfffb6f967c6c (diff)
downloadcpython-3d139d8ed6712f39f4e91dc084ed421b76af09ae.zip
cpython-3d139d8ed6712f39f4e91dc084ed421b76af09ae.tar.gz
cpython-3d139d8ed6712f39f4e91dc084ed421b76af09ae.tar.bz2
asyncio: Fix the second half of issue #21447: race in _write_to_self().
Diffstat (limited to 'Lib/asyncio/selector_events.py')
-rw-r--r--Lib/asyncio/selector_events.py15
1 files changed, 11 insertions, 4 deletions
diff --git a/Lib/asyncio/selector_events.py b/Lib/asyncio/selector_events.py
index 367c5fb..c7df8d8 100644
--- a/Lib/asyncio/selector_events.py
+++ b/Lib/asyncio/selector_events.py
@@ -87,10 +87,17 @@ class BaseSelectorEventLoop(base_events.BaseEventLoop):
pass
def _write_to_self(self):
- try:
- self._csock.send(b'x')
- except (BlockingIOError, InterruptedError):
- pass
+ # This may be called from a different thread, possibly after
+ # _close_self_pipe() has been called or even while it is
+ # running. Guard for self._csock being None or closed. When
+ # a socket is closed, send() raises OSError (with errno set to
+ # EBADF, but let's not rely on the exact error code).
+ csock = self._csock
+ if csock is not None:
+ try:
+ csock.send(b'x')
+ except OSError:
+ pass
def _start_serving(self, protocol_factory, sock,
sslcontext=None, server=None):