diff options
| author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2023-10-02 15:03:51 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-02 15:03:51 (GMT) |
| commit | 5ba9d2b98f13c509cec560cb1de8de1630463e5c (patch) | |
| tree | 23a496da0d012935e078265576077a23af2070e3 /Lib/asyncio/unix_events.py | |
| parent | c3038bed1df2dc0399379cec81544a3d725674ef (diff) | |
| download | cpython-5ba9d2b98f13c509cec560cb1de8de1630463e5c.zip cpython-5ba9d2b98f13c509cec560cb1de8de1630463e5c.tar.gz cpython-5ba9d2b98f13c509cec560cb1de8de1630463e5c.tar.bz2 | |
[3.12] gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (GH-109431) (#109609)
gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (GH-109431)
SubprocessProtocol process_exited() method can be called before
pipe_data_received() and pipe_connection_lost() methods. Document it
and adapt the test for that.
Revert commit 282edd7b2a74c4dfe1bfe3c5b1d30f9c21d554d6.
_child_watcher_callback() calls immediately _process_exited(): don't
add an additional delay with call_soon(). The reverted change didn't
make _process_exited() more determistic: it can still be called
before pipe_connection_lost() for example.
(cherry picked from commit ced6924630037f1e5b3d1dbef2b600152fb07fbb)
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Davide Rizzo <sorcio@gmail.com>
Diffstat (limited to 'Lib/asyncio/unix_events.py')
| -rw-r--r-- | Lib/asyncio/unix_events.py | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py index 17fb4d5..f985f97 100644 --- a/Lib/asyncio/unix_events.py +++ b/Lib/asyncio/unix_events.py @@ -226,8 +226,7 @@ class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop): return transp def _child_watcher_callback(self, pid, returncode, transp): - # Skip one iteration for callbacks to be executed - self.call_soon_threadsafe(self.call_soon, transp._process_exited, returncode) + self.call_soon_threadsafe(transp._process_exited, returncode) async def create_unix_connection( self, protocol_factory, path=None, *, |