diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2014-07-16 16:36:24 (GMT) |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2014-07-16 16:36:24 (GMT) |
commit | f03b3c75647219110924197bb26e83dd69f826f5 (patch) | |
tree | e17fb84d7b44408b2581b684dcdc7bd62ab0d183 /Lib/asyncio | |
parent | 1314f06293393bf5ec403a39dffe3f4c33b88bc4 (diff) | |
download | cpython-f03b3c75647219110924197bb26e83dd69f826f5.zip cpython-f03b3c75647219110924197bb26e83dd69f826f5.tar.gz cpython-f03b3c75647219110924197bb26e83dd69f826f5.tar.bz2 |
Issue #21163, asyncio: Ignore "destroy pending task" warnings for private tasks
in gather().
Diffstat (limited to 'Lib/asyncio')
-rw-r--r-- | Lib/asyncio/tasks.py | 34 |
1 files changed, 23 insertions, 11 deletions
diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py index 78b4c4d..a741bd3 100644 --- a/Lib/asyncio/tasks.py +++ b/Lib/asyncio/tasks.py @@ -558,21 +558,33 @@ def gather(*coros_or_futures, loop=None, return_exceptions=False): prevent the cancellation of one child to cause other children to be cancelled.) """ - arg_to_fut = {arg: async(arg, loop=loop) for arg in set(coros_or_futures)} - children = [arg_to_fut[arg] for arg in coros_or_futures] - n = len(children) - if n == 0: + if not coros_or_futures: outer = futures.Future(loop=loop) outer.set_result([]) return outer - if loop is None: - loop = children[0]._loop - for fut in children: - if fut._loop is not loop: - raise ValueError("futures are tied to different event loops") + + arg_to_fut = {} + for arg in set(coros_or_futures): + if not isinstance(arg, futures.Future): + fut = async(arg, loop=loop) + if loop is None: + loop = fut._loop + # The caller cannot control this future, the "destroy pending task" + # warning should not be emitted. + fut._log_destroy_pending = False + else: + fut = arg + if loop is None: + loop = fut._loop + elif fut._loop is not loop: + raise ValueError("futures are tied to different event loops") + arg_to_fut[arg] = fut + + children = [arg_to_fut[arg] for arg in coros_or_futures] + nchildren = len(children) outer = _GatheringFuture(children, loop=loop) nfinished = 0 - results = [None] * n + results = [None] * nchildren def _done_callback(i, fut): nonlocal nfinished @@ -595,7 +607,7 @@ def gather(*coros_or_futures, loop=None, return_exceptions=False): res = fut._result results[i] = res nfinished += 1 - if nfinished == n: + if nfinished == nchildren: outer.set_result(results) for i, fut in enumerate(children): |