diff options
author | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2020-07-23 20:02:47 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-07-23 20:02:47 (GMT) |
commit | 4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d (patch) | |
tree | 754e2eeeb724a9a7e2c2ea049fd416c89287cb2d /Lib/asyncio | |
parent | e8dda907fbeb957436d2662714d993b073be55bb (diff) | |
download | cpython-4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d.zip cpython-4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d.tar.gz cpython-4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d.tar.bz2 |
bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (GH-21595)
(cherry picked from commit 0dd98c2d00a75efbec19c2ed942923981bc06683)
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
Diffstat (limited to 'Lib/asyncio')
-rw-r--r-- | Lib/asyncio/selector_events.py | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/Lib/asyncio/selector_events.py b/Lib/asyncio/selector_events.py index 884a58f..8495a79 100644 --- a/Lib/asyncio/selector_events.py +++ b/Lib/asyncio/selector_events.py @@ -555,20 +555,19 @@ class BaseSelectorEventLoop(base_events.BaseEventLoop): if self._debug and sock.gettimeout() != 0: raise ValueError("the socket must be non-blocking") fut = self.create_future() - self._sock_accept(fut, False, sock) + self._sock_accept(fut, sock) return await fut - def _sock_accept(self, fut, registered, sock): + def _sock_accept(self, fut, sock): fd = sock.fileno() - if registered: - self.remove_reader(fd) - if fut.done(): - return try: conn, address = sock.accept() conn.setblocking(False) except (BlockingIOError, InterruptedError): - self.add_reader(fd, self._sock_accept, fut, True, sock) + self._ensure_fd_no_transport(fd) + handle = self._add_reader(fd, self._sock_accept, fut, sock) + fut.add_done_callback( + functools.partial(self._sock_read_done, fd, handle=handle)) except (SystemExit, KeyboardInterrupt): raise except BaseException as exc: |