summaryrefslogtreecommitdiffstats
path: root/Lib/collections.py
diff options
context:
space:
mode:
authorRaymond Hettinger <python@rcn.com>2007-12-05 18:11:08 (GMT)
committerRaymond Hettinger <python@rcn.com>2007-12-05 18:11:08 (GMT)
commit2e1af256d475543a1a6c0c8c54cb2497560600bc (patch)
treea6e8ccb7fbd5959e442ae7eed6996cc6de3718fa /Lib/collections.py
parent722e1011c937ee6adb3fbb37c00fc58315ba0918 (diff)
downloadcpython-2e1af256d475543a1a6c0c8c54cb2497560600bc.zip
cpython-2e1af256d475543a1a6c0c8c54cb2497560600bc.tar.gz
cpython-2e1af256d475543a1a6c0c8c54cb2497560600bc.tar.bz2
Error checking was too aggressive (reported by Chris Tismer)
Diffstat (limited to 'Lib/collections.py')
-rw-r--r--Lib/collections.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/Lib/collections.py b/Lib/collections.py
index 356d961..e551f20 100644
--- a/Lib/collections.py
+++ b/Lib/collections.py
@@ -40,7 +40,7 @@ def namedtuple(typename, field_names, verbose=False):
field_names = field_names.replace(',', ' ').split() # names separated by whitespace and/or commas
field_names = tuple(field_names)
for name in (typename,) + field_names:
- if not name.replace('_', '').isalnum():
+ if not all(c.isalnum() or c=='_' for c in name):
raise ValueError('Type names and field names can only contain alphanumeric characters and underscores: %r' % name)
if _iskeyword(name):
raise ValueError('Type names and field names cannot be a keyword: %r' % name)
@@ -48,7 +48,7 @@ def namedtuple(typename, field_names, verbose=False):
raise ValueError('Type names and field names cannot start with a number: %r' % name)
seen_names = set()
for name in field_names:
- if name.startswith('__') and name.endswith('__'):
+ if name.startswith('__') and name.endswith('__') and len(name) > 3:
raise ValueError('Field names cannot start and end with double underscores: %r' % name)
if name in seen_names:
raise ValueError('Encountered duplicate field name: %r' % name)