diff options
| author | Brett Cannon <brett@python.org> | 2015-12-27 21:17:04 (GMT) |
|---|---|---|
| committer | Brett Cannon <brett@python.org> | 2015-12-27 21:17:04 (GMT) |
| commit | 1e3c3e906c9f1fcc463cfb3641d078eec773666f (patch) | |
| tree | 72e1e89b587158cd61dcd55d62a8a24dbf838011 /Lib/compileall.py | |
| parent | 4a4ca7c13f65d54087bf6add854bbbc23db1541f (diff) | |
| download | cpython-1e3c3e906c9f1fcc463cfb3641d078eec773666f.zip cpython-1e3c3e906c9f1fcc463cfb3641d078eec773666f.tar.gz cpython-1e3c3e906c9f1fcc463cfb3641d078eec773666f.tar.bz2 | |
Issue #25768: Make compileall functions return booleans and document
the return values as well as test them.
Thanks to Nicholas Chammas for the bug report and initial patch.
Diffstat (limited to 'Lib/compileall.py')
| -rw-r--r-- | Lib/compileall.py | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/Lib/compileall.py b/Lib/compileall.py index 0cc0c1d..67c5f5a 100644 --- a/Lib/compileall.py +++ b/Lib/compileall.py @@ -68,7 +68,7 @@ def compile_dir(dir, maxlevels=10, ddir=None, force=False, rx=None, """ files = _walk_dir(dir, quiet=quiet, maxlevels=maxlevels, ddir=ddir) - success = 1 + success = True if workers is not None and workers != 1 and ProcessPoolExecutor is not None: if workers < 0: raise ValueError('workers must be greater or equal to 0') @@ -81,12 +81,12 @@ def compile_dir(dir, maxlevels=10, ddir=None, force=False, rx=None, legacy=legacy, optimize=optimize), files) - success = min(results, default=1) + success = min(results, default=True) else: for file in files: if not compile_file(file, ddir, force, rx, quiet, legacy, optimize): - success = 0 + success = False return success def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0, @@ -104,7 +104,7 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0, legacy: if True, produce legacy pyc paths instead of PEP 3147 paths optimize: optimization level or -1 for level of the interpreter """ - success = 1 + success = True name = os.path.basename(fullname) if ddir is not None: dfile = os.path.join(ddir, name) @@ -144,7 +144,7 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0, ok = py_compile.compile(fullname, cfile, dfile, True, optimize=optimize) except py_compile.PyCompileError as err: - success = 0 + success = False if quiet >= 2: return success elif quiet: @@ -157,7 +157,7 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0, msg = msg.decode(sys.stdout.encoding) print(msg) except (SyntaxError, UnicodeError, OSError) as e: - success = 0 + success = False if quiet >= 2: return success elif quiet: @@ -167,7 +167,7 @@ def compile_file(fullname, ddir=None, force=False, rx=None, quiet=0, print(e.__class__.__name__ + ':', e) else: if ok == 0: - success = 0 + success = False return success def compile_path(skip_curdir=1, maxlevels=0, force=False, quiet=0, @@ -183,7 +183,7 @@ def compile_path(skip_curdir=1, maxlevels=0, force=False, quiet=0, legacy: as for compile_dir() (default False) optimize: as for compile_dir() (default -1) """ - success = 1 + success = True for dir in sys.path: if (not dir or dir == os.curdir) and skip_curdir: if quiet < 2: |