summaryrefslogtreecommitdiffstats
path: root/Lib/contextlib.py
diff options
context:
space:
mode:
authorIrit Katriel <1055913+iritkatriel@users.noreply.github.com>2023-07-20 09:11:32 (GMT)
committerGitHub <noreply@github.com>2023-07-20 09:11:32 (GMT)
commiteeff8e72349743f37524221fe9e8f860879b46b3 (patch)
tree3750da97130c5379bb25463fab86a8448a909b3b /Lib/contextlib.py
parent832c37d42a395d4ea45994daffa5e41bd74ac1bb (diff)
downloadcpython-eeff8e72349743f37524221fe9e8f860879b46b3.zip
cpython-eeff8e72349743f37524221fe9e8f860879b46b3.tar.gz
cpython-eeff8e72349743f37524221fe9e8f860879b46b3.tar.bz2
gh-102799: use sys.exception() instead of sys.exc_info() in contextlib (#103311)
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Diffstat (limited to 'Lib/contextlib.py')
-rw-r--r--Lib/contextlib.py54
1 files changed, 32 insertions, 22 deletions
diff --git a/Lib/contextlib.py b/Lib/contextlib.py
index 95947ac..f82e7bc 100644
--- a/Lib/contextlib.py
+++ b/Lib/contextlib.py
@@ -557,11 +557,12 @@ class ExitStack(_BaseExitStack, AbstractContextManager):
return self
def __exit__(self, *exc_details):
- received_exc = exc_details[0] is not None
+ exc = exc_details[1]
+ received_exc = exc is not None
# We manipulate the exception state so it behaves as though
# we were actually nesting multiple with statements
- frame_exc = sys.exc_info()[1]
+ frame_exc = sys.exception()
def _fix_exception_context(new_exc, old_exc):
# Context may not be correct, so find the end of the chain
while 1:
@@ -584,24 +585,28 @@ class ExitStack(_BaseExitStack, AbstractContextManager):
is_sync, cb = self._exit_callbacks.pop()
assert is_sync
try:
+ if exc is None:
+ exc_details = None, None, None
+ else:
+ exc_details = type(exc), exc, exc.__traceback__
if cb(*exc_details):
suppressed_exc = True
pending_raise = False
- exc_details = (None, None, None)
- except:
- new_exc_details = sys.exc_info()
+ exc = None
+ except BaseException as new_exc:
# simulate the stack of exceptions by setting the context
- _fix_exception_context(new_exc_details[1], exc_details[1])
+ _fix_exception_context(new_exc, exc)
pending_raise = True
- exc_details = new_exc_details
+ exc = new_exc
+
if pending_raise:
try:
- # bare "raise exc_details[1]" replaces our carefully
+ # bare "raise exc" replaces our carefully
# set-up context
- fixed_ctx = exc_details[1].__context__
- raise exc_details[1]
+ fixed_ctx = exc.__context__
+ raise exc
except BaseException:
- exc_details[1].__context__ = fixed_ctx
+ exc.__context__ = fixed_ctx
raise
return received_exc and suppressed_exc
@@ -697,11 +702,12 @@ class AsyncExitStack(_BaseExitStack, AbstractAsyncContextManager):
return self
async def __aexit__(self, *exc_details):
- received_exc = exc_details[0] is not None
+ exc = exc_details[1]
+ received_exc = exc is not None
# We manipulate the exception state so it behaves as though
# we were actually nesting multiple with statements
- frame_exc = sys.exc_info()[1]
+ frame_exc = sys.exception()
def _fix_exception_context(new_exc, old_exc):
# Context may not be correct, so find the end of the chain
while 1:
@@ -723,6 +729,10 @@ class AsyncExitStack(_BaseExitStack, AbstractAsyncContextManager):
while self._exit_callbacks:
is_sync, cb = self._exit_callbacks.pop()
try:
+ if exc is None:
+ exc_details = None, None, None
+ else:
+ exc_details = type(exc), exc, exc.__traceback__
if is_sync:
cb_suppress = cb(*exc_details)
else:
@@ -731,21 +741,21 @@ class AsyncExitStack(_BaseExitStack, AbstractAsyncContextManager):
if cb_suppress:
suppressed_exc = True
pending_raise = False
- exc_details = (None, None, None)
- except:
- new_exc_details = sys.exc_info()
+ exc = None
+ except BaseException as new_exc:
# simulate the stack of exceptions by setting the context
- _fix_exception_context(new_exc_details[1], exc_details[1])
+ _fix_exception_context(new_exc, exc)
pending_raise = True
- exc_details = new_exc_details
+ exc = new_exc
+
if pending_raise:
try:
- # bare "raise exc_details[1]" replaces our carefully
+ # bare "raise exc" replaces our carefully
# set-up context
- fixed_ctx = exc_details[1].__context__
- raise exc_details[1]
+ fixed_ctx = exc.__context__
+ raise exc
except BaseException:
- exc_details[1].__context__ = fixed_ctx
+ exc.__context__ = fixed_ctx
raise
return received_exc and suppressed_exc