summaryrefslogtreecommitdiffstats
path: root/Lib/doctest.py
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2012-09-10 14:15:58 (GMT)
committerR David Murray <rdmurray@bitdance.com>2012-09-10 14:15:58 (GMT)
commit5abd76a75d633a1ba6f5fcc66b0bc4799b9e2eaa (patch)
treef5f595962bd537e345bb6b567e8bc3cd6a14418e /Lib/doctest.py
parent01beb69c7dacc0a59acd568239322716da6e55d0 (diff)
downloadcpython-5abd76a75d633a1ba6f5fcc66b0bc4799b9e2eaa.zip
cpython-5abd76a75d633a1ba6f5fcc66b0bc4799b9e2eaa.tar.gz
cpython-5abd76a75d633a1ba6f5fcc66b0bc4799b9e2eaa.tar.bz2
#14649: clarify DocTestSuite error when there are no docstrings.
Also adds tests to verify the documented behavior (which is probably a bug, as indicated in the added comments). Patch by Chris Jerdonek.
Diffstat (limited to 'Lib/doctest.py')
-rw-r--r--Lib/doctest.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/Lib/doctest.py b/Lib/doctest.py
index cc3b425..e189c8f 100644
--- a/Lib/doctest.py
+++ b/Lib/doctest.py
@@ -2333,7 +2333,12 @@ def DocTestSuite(module=None, globs=None, extraglobs=None, test_finder=None,
elif not tests:
# Why do we want to do this? Because it reveals a bug that might
# otherwise be hidden.
- raise ValueError(module, "has no tests")
+ # It is probably a bug that this exception is not also raised if the
+ # number of doctest examples in tests is zero (i.e. if no doctest
+ # examples were found). However, we should probably not be raising
+ # an exception at all here, though it is too late to make this change
+ # for a maintenance release. See also issue #14649.
+ raise ValueError(module, "has no docstrings")
tests.sort()
suite = unittest.TestSuite()