summaryrefslogtreecommitdiffstats
path: root/Lib/functools.py
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2010-08-23 17:40:33 (GMT)
committerBenjamin Peterson <benjamin@python.org>2010-08-23 17:40:33 (GMT)
commit9c2930e4bedcbb09d8a0cd484dec72c6246f6735 (patch)
tree1f515d00f8789d908edb2d2a5a5ee68aa0439fd0 /Lib/functools.py
parent7311729790172a6f85db0c31299f06feba217e87 (diff)
downloadcpython-9c2930e4bedcbb09d8a0cd484dec72c6246f6735.zip
cpython-9c2930e4bedcbb09d8a0cd484dec72c6246f6735.tar.gz
cpython-9c2930e4bedcbb09d8a0cd484dec72c6246f6735.tar.bz2
run total_ordering() tests, and fix the function (default comparisons shouldn't be considered)
Diffstat (limited to 'Lib/functools.py')
-rw-r--r--Lib/functools.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/Lib/functools.py b/Lib/functools.py
index bd1334b..7ce6bc2 100644
--- a/Lib/functools.py
+++ b/Lib/functools.py
@@ -65,6 +65,7 @@ def wraps(wrapped,
return partial(update_wrapper, wrapped=wrapped,
assigned=assigned, updated=updated)
+_object_defaults = {object.__lt__, object.__le__, object.__gt__, object.__ge__}
def total_ordering(cls):
"""Class decorator that fills in missing ordering methods"""
convert = {
@@ -81,7 +82,9 @@ def total_ordering(cls):
('__gt__', lambda self, other: not other >= self),
('__lt__', lambda self, other: not self >= other)]
}
- roots = set(dir(cls)) & set(convert)
+ roots = (set(dir(cls)) & set(convert))
+ # Remove default comparison operations defined on object.
+ roots -= {meth for meth in roots if getattr(cls, meth) in _object_defaults}
if not roots:
raise ValueError('must define at least one ordering operation: < > <= >=')
root = max(roots) # prefer __lt__ to __le__ to __gt__ to __ge__