summaryrefslogtreecommitdiffstats
path: root/Lib/idlelib/pyshell.py
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-09-06 09:14:24 (GMT)
committerVictor Stinner <vstinner@redhat.com>2019-09-06 09:14:24 (GMT)
commit1e2707d7e82aedf73c59772bc7aa228286323c3c (patch)
treeaf464c4cd5fd147ef3c4fff1f851a4357a92f4af /Lib/idlelib/pyshell.py
parent256f03befb1f144340e11bc6eee92d3afd84ee23 (diff)
downloadcpython-1e2707d7e82aedf73c59772bc7aa228286323c3c.zip
cpython-1e2707d7e82aedf73c59772bc7aa228286323c3c.tar.gz
cpython-1e2707d7e82aedf73c59772bc7aa228286323c3c.tar.bz2
bpo-37380: subprocess: don't use _active on win (GH-14360) (GH-15706)
As noted by @eryksun in [1] and [2], using _cleanup and _active(in __del__) is not necessary on Windows, since: > Unlike Unix, a process in Windows doesn't have to be waited on by > its parent to avoid a zombie. Keeping the handle open will actually > create a zombie until the next _cleanup() call, which may be never > if Popen() isn't called again. This patch simply defines `subprocess._active` as `None`, for which we already have the proper logic in place in `subprocess.Popen.__del__`, that prevents it from trying to append the process to the `_active`. This patch also defines `subprocess._cleanup` as a noop for Windows. [1] https://bugs.python.org/issue37380GH-msg346333 [2] https://bugs.python.org/issue36067GH-msg336262 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai> (cherry picked from commit 042821ae3cf537e01963c9ec85d1a454d921e826) Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Diffstat (limited to 'Lib/idlelib/pyshell.py')
0 files changed, 0 insertions, 0 deletions