summaryrefslogtreecommitdiffstats
path: root/Lib/idlelib
diff options
context:
space:
mode:
authorTerry Jan Reedy <tjreedy@udel.edu>2023-05-18 01:36:58 (GMT)
committerGitHub <noreply@github.com>2023-05-18 01:36:58 (GMT)
commit678bf57ed04b8c250f0bc031ebd264bece76e731 (patch)
tree1e48de3374968414bc4f3d06eab7833b3efdd621 /Lib/idlelib
parent7fc8e2d4627cdba5cb0075c9052ed6f4b6ecd36d (diff)
downloadcpython-678bf57ed04b8c250f0bc031ebd264bece76e731.zip
cpython-678bf57ed04b8c250f0bc031ebd264bece76e731.tar.gz
cpython-678bf57ed04b8c250f0bc031ebd264bece76e731.tar.bz2
gh-104499: IDLE - fix completions for tk aqua 8.7 (#104591)
Diffstat (limited to 'Lib/idlelib')
-rw-r--r--Lib/idlelib/NEWS.txt2
-rw-r--r--Lib/idlelib/autocomplete_w.py10
2 files changed, 5 insertions, 7 deletions
diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt
index f78e45e..553b932 100644
--- a/Lib/idlelib/NEWS.txt
+++ b/Lib/idlelib/NEWS.txt
@@ -4,6 +4,8 @@ Released on 2023-10-02
=========================
+gh-104499: Fix completions for Tk Aqua 8.7 (currently blank).
+
gh-104486: Make About print both tcl and tk versions if different,
as is expected someday.
diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py
index 0f835a9..5bd7ce7 100644
--- a/Lib/idlelib/autocomplete_w.py
+++ b/Lib/idlelib/autocomplete_w.py
@@ -182,16 +182,11 @@ class AutoCompleteWindow:
self.userwantswindow = userWantsWin
self.lasttypedstart = self.start
- # Put widgets in place
self.autocompletewindow = acw = Toplevel(self.widget)
- # Put it in a position so that it is not seen.
- acw.wm_geometry("+10000+10000")
- # Make it float
+ acw.withdraw()
acw.wm_overrideredirect(1)
try:
- # This command is only needed and available on Tk >= 8.4.0 for OSX
- # Without it, call tips intrude on the typing process by grabbing
- # the focus.
+ # Prevent grabbing focus on maxOS.
acw.tk.call("::tk::unsupported::MacWindowStyle", "style", acw._w,
"help", "noActivates")
except TclError:
@@ -271,6 +266,7 @@ class AutoCompleteWindow:
# place acw above current line
new_y -= acw_height
acw.wm_geometry("+%d+%d" % (new_x, new_y))
+ acw.deiconify()
acw.update_idletasks()
except TclError:
pass