diff options
author | Brett Cannon <brett@python.org> | 2012-06-16 00:00:53 (GMT) |
---|---|---|
committer | Brett Cannon <brett@python.org> | 2012-06-16 00:00:53 (GMT) |
commit | ea0b8239401123fa7f41c74f6fc9ded1cf74088a (patch) | |
tree | 6d5afa0b55c1c5e1e39770d062b25d81a231535b /Lib/importlib/_bootstrap.py | |
parent | 0450c9ed52deccd087c56b4da36f02c800c604a5 (diff) | |
download | cpython-ea0b8239401123fa7f41c74f6fc9ded1cf74088a.zip cpython-ea0b8239401123fa7f41c74f6fc9ded1cf74088a.tar.gz cpython-ea0b8239401123fa7f41c74f6fc9ded1cf74088a.tar.bz2 |
Issue #14938: importlib.abc.SourceLoader.is_package() now takes the
module name into consideration when determining whether a module is a
package or not. This prevents importing a module's __init__ module
directly and having it considered a package, which can lead to
duplicate sub-modules.
Thanks to Ronan Lamy for reporting the bug.
Diffstat (limited to 'Lib/importlib/_bootstrap.py')
-rw-r--r-- | Lib/importlib/_bootstrap.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/Lib/importlib/_bootstrap.py b/Lib/importlib/_bootstrap.py index 6656db3..117c0f6 100644 --- a/Lib/importlib/_bootstrap.py +++ b/Lib/importlib/_bootstrap.py @@ -578,7 +578,9 @@ class _LoaderBasics: """Concrete implementation of InspectLoader.is_package by checking if the path returned by get_filename has a filename of '__init__.py'.""" filename = _path_split(self.get_filename(fullname))[1] - return filename.rsplit('.', 1)[0] == '__init__' + filename_base = filename.rsplit('.', 1)[0] + tail_name = fullname.rpartition('.')[2] + return filename_base == '__init__' and tail_name != '__init__' def _bytes_from_bytecode(self, fullname, data, bytecode_path, source_stats): """Return the marshalled bytes from bytecode, verifying the magic |