summaryrefslogtreecommitdiffstats
path: root/Lib/importlib/test/source
diff options
context:
space:
mode:
authorBrett Cannon <brett@python.org>2012-06-16 00:00:53 (GMT)
committerBrett Cannon <brett@python.org>2012-06-16 00:00:53 (GMT)
commitea0b8239401123fa7f41c74f6fc9ded1cf74088a (patch)
tree6d5afa0b55c1c5e1e39770d062b25d81a231535b /Lib/importlib/test/source
parent0450c9ed52deccd087c56b4da36f02c800c604a5 (diff)
downloadcpython-ea0b8239401123fa7f41c74f6fc9ded1cf74088a.zip
cpython-ea0b8239401123fa7f41c74f6fc9ded1cf74088a.tar.gz
cpython-ea0b8239401123fa7f41c74f6fc9ded1cf74088a.tar.bz2
Issue #14938: importlib.abc.SourceLoader.is_package() now takes the
module name into consideration when determining whether a module is a package or not. This prevents importing a module's __init__ module directly and having it considered a package, which can lead to duplicate sub-modules. Thanks to Ronan Lamy for reporting the bug.
Diffstat (limited to 'Lib/importlib/test/source')
-rw-r--r--Lib/importlib/test/source/test_abc_loader.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/Lib/importlib/test/source/test_abc_loader.py b/Lib/importlib/test/source/test_abc_loader.py
index b1b1204..fc98b93 100644
--- a/Lib/importlib/test/source/test_abc_loader.py
+++ b/Lib/importlib/test/source/test_abc_loader.py
@@ -602,10 +602,11 @@ class SourceOnlyLoaderTests(SourceLoaderTestHarness):
def test_is_package(self):
# Properly detect when loading a package.
- self.setUp(is_package=True)
- self.assertTrue(self.loader.is_package(self.name))
self.setUp(is_package=False)
self.assertFalse(self.loader.is_package(self.name))
+ self.setUp(is_package=True)
+ self.assertTrue(self.loader.is_package(self.name))
+ self.assertFalse(self.loader.is_package(self.name + '.__init__'))
def test_get_code(self):
# Verify the code object is created.