diff options
| author | Brett Cannon <brett@python.org> | 2021-03-30 15:43:03 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-30 15:43:03 (GMT) |
| commit | a7ff6df60c05e1b69fca743573b1e118bebf121d (patch) | |
| tree | 7dae896ba674245645b5ca46c02cc387a43d35a0 /Lib/importlib | |
| parent | cf35e05f89bb008d6f4553f9875e0fe87fc02406 (diff) | |
| download | cpython-a7ff6df60c05e1b69fca743573b1e118bebf121d.zip cpython-a7ff6df60c05e1b69fca743573b1e118bebf121d.tar.gz cpython-a7ff6df60c05e1b69fca743573b1e118bebf121d.tar.bz2 | |
bpo-42134: Raise ImportWarning when calling find_module() in the import system (GH-25044)
Diffstat (limited to 'Lib/importlib')
| -rw-r--r-- | Lib/importlib/_bootstrap.py | 5 | ||||
| -rw-r--r-- | Lib/importlib/_bootstrap_external.py | 3 |
2 files changed, 6 insertions, 2 deletions
diff --git a/Lib/importlib/_bootstrap.py b/Lib/importlib/_bootstrap.py index d5acb65..ab52e77 100644 --- a/Lib/importlib/_bootstrap.py +++ b/Lib/importlib/_bootstrap.py @@ -903,8 +903,9 @@ def _resolve_name(name, package, level): def _find_spec_legacy(finder, name, path): - # This would be a good place for a DeprecationWarning if - # we ended up going that route. + msg = (f"{_object_name(finder)}.find_spec() not found; " + "falling back to find_module()") + _warnings.warn(msg, ImportWarning) loader = finder.find_module(name, path) if loader is None: return None diff --git a/Lib/importlib/_bootstrap_external.py b/Lib/importlib/_bootstrap_external.py index dac881f..bf7c268 100644 --- a/Lib/importlib/_bootstrap_external.py +++ b/Lib/importlib/_bootstrap_external.py @@ -1324,6 +1324,9 @@ class PathFinder: if hasattr(finder, 'find_loader'): loader, portions = finder.find_loader(fullname) else: + msg = (f"{_bootstrap._object_name(finder)}.find_spec() not found; " + "falling back to find_module()") + _warnings.warn(msg, ImportWarning) loader = finder.find_module(fullname) portions = [] if loader is not None: |