diff options
| author | Brett Cannon <brett@python.org> | 2021-03-26 18:55:07 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-26 18:55:07 (GMT) |
| commit | 1899087b21119c5c64cd41619b542c0bf0ab5751 (patch) | |
| tree | 400c834041ef28eacaac8fa0169e2482dea8a775 /Lib/importlib | |
| parent | 21a2cabb3795f5170c746ab8f29e9d25c7442550 (diff) | |
| download | cpython-1899087b21119c5c64cd41619b542c0bf0ab5751.zip cpython-1899087b21119c5c64cd41619b542c0bf0ab5751.tar.gz cpython-1899087b21119c5c64cd41619b542c0bf0ab5751.tar.bz2 | |
bpo-42136: Deprecate module_repr() as found in importlib (GH-25022)
Diffstat (limited to 'Lib/importlib')
| -rw-r--r-- | Lib/importlib/_abc.py | 3 | ||||
| -rw-r--r-- | Lib/importlib/_bootstrap.py | 6 | ||||
| -rw-r--r-- | Lib/importlib/_bootstrap_external.py | 2 |
3 files changed, 9 insertions, 2 deletions
diff --git a/Lib/importlib/_abc.py b/Lib/importlib/_abc.py index 7591946..f80348f 100644 --- a/Lib/importlib/_abc.py +++ b/Lib/importlib/_abc.py @@ -1,6 +1,7 @@ """Subset of importlib.abc used to reduce importlib.util imports.""" from . import _bootstrap import abc +import warnings class Loader(metaclass=abc.ABCMeta): @@ -47,5 +48,7 @@ class Loader(metaclass=abc.ABCMeta): This method is deprecated. """ + warnings.warn("importlib.abc.Loader.module_repr() is deprecated and " + "slated for removal in Python 3.12", DeprecationWarning) # The exception will cause ModuleType.__repr__ to ignore this method. raise NotImplementedError diff --git a/Lib/importlib/_bootstrap.py b/Lib/importlib/_bootstrap.py index 5038b46..d5acb65 100644 --- a/Lib/importlib/_bootstrap.py +++ b/Lib/importlib/_bootstrap.py @@ -302,8 +302,6 @@ def _module_repr(module): except Exception: pass # Fall through to a catch-all which always succeeds. - # We could use module.__class__.__name__ instead of 'module' in the - # various repr permutations. try: name = module.__name__ except AttributeError: @@ -741,6 +739,8 @@ class BuiltinImporter: The method is deprecated. The import machinery does the job itself. """ + _warnings.warn("BuiltinImporter.module_repr() is deprecated and " + "slated for removal in Python 3.12", DeprecationWarning) return f'<module {module.__name__!r} ({BuiltinImporter._ORIGIN})>' @classmethod @@ -816,6 +816,8 @@ class FrozenImporter: The method is deprecated. The import machinery does the job itself. """ + _warnings.warn("FrozenImporter.module_repr() is deprecated and " + "slated for removal in Python 3.12", DeprecationWarning) return '<module {!r} ({})>'.format(m.__name__, FrozenImporter._ORIGIN) @classmethod diff --git a/Lib/importlib/_bootstrap_external.py b/Lib/importlib/_bootstrap_external.py index 2dab45d..dac881f 100644 --- a/Lib/importlib/_bootstrap_external.py +++ b/Lib/importlib/_bootstrap_external.py @@ -1230,6 +1230,8 @@ class _NamespaceLoader: The method is deprecated. The import machinery does the job itself. """ + _warnings.warn("_NamespaceLoader.module_repr() is deprecated and " + "slated for removal in Python 3.12", DeprecationWarning) return '<module {!r} (namespace)>'.format(module.__name__) def is_package(self, fullname): |